revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 20:40:56 +01:00
Code Issues Releases Wiki Activity

Fix fatal in commit message parser

Browse source 
Summary:
See D1195, which fataled this daemon.

https://secure.phabricator.com/daemon/log/2966/

Test Plan: Applied this patch to secure.phabricator.com, restarted daemon, it
picked up D1203.

Reviewers: btrahan, jungejason, mareksapota

Reviewed By: btrahan

CC: aran, btrahan, mareksapota

Differential Revision: 1204
This commit is contained in:
epriestley 2011-12-13 18:42:26 -08:00
parent 2efd8fe971
commit 51b8168253
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/repository/worker/commitmessageparser/base/PhabricatorRepositoryCommitMessageParserWorker.php
View file

@ -96,11 +96,9 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
$commit->getPHID()); $commit->getPHID());
if ($revision->getStatus() != DifferentialRevisionStatus::COMMITTED) { if ($revision->getStatus() != DifferentialRevisionStatus::COMMITTED) {
$committer = null;
$message = null; $message = null;
if ($commit->getDetail('authorPHID')) { $committer = $data->getCommitDetail('authorPHID');
$committer = $commit->getDetail('authorPHID'); if (!$committer) {
} else {
$committer = $revision->getAuthorPHID(); $committer = $revision->getAuthorPHID();
$message = 'Change committed by '.$commit->getAuthorName().'.'; $message = 'Change committed by '.$commit->getAuthorName().'.';
} }