revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-28 12:08:14 +01:00
Code Issues Releases Wiki Activity

Make all revision status readers explicitly read modern or legacy status

Browse source 
Summary: Ref T2543. All writers now write modern statuses. Make all readers explicit about whether they are reading modern or legacy statuses, so I can swap the storage format.

Test Plan:
  - Grepped for `getStatus()`, scanned the list. Other applications have methods with this name so it's possible I missed something.
  - Browed around, changed revision statuses.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18417
This commit is contained in:
epriestley 2017-08-11 16:21:28 -07:00
parent 0b1d6a3f6e
commit 5348f34c9e
6 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/conduit/DifferentialGetRevisionConduitAPIMethod.php
View file

@ -82,7 +82,7 @@ final class DifferentialGetRevisionConduitAPIMethod
'authorPHID' => $revision->getAuthorPHID(),
'uri' => PhabricatorEnv::getURI('/D'.$revision->getID()),
'title' => $revision->getTitle(),
'status' => $revision->getStatus(),
'status' => $revision->getLegacyRevisionStatus(),
'statusName' => $revision->getStatusDisplayName(),
'summary' => $revision->getSummary(),
'testPlan' => $revision->getTestPlan(),

2
src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
View file

@ -218,7 +218,7 @@ final class DifferentialQueryConduitAPIMethod
'dateCreated' => $revision->getDateCreated(),
'dateModified' => $revision->getDateModified(),
'authorPHID' => $revision->getAuthorPHID(),
'status' => $revision->getStatus(),
'status' => $revision->getLegacyRevisionStatus(),
'statusName' => $revision->getStatusDisplayName(),
'properties' => $revision->getProperties(),
'branch' => $diff->getBranch(),

4
src/applications/differential/editor/DifferentialTransactionEditor.php
View file

@ -535,9 +535,9 @@ final class DifferentialTransactionEditor
return $xactions;
}
$old_legacy_status = $revision->getStatus();
$old_legacy_status = $revision->getLegacyRevisionStatus();
$revision->setModernRevisionStatus($new_status);
$new_legacy_status = $revision->getStatus();
$new_legacy_status = $revision->getLegacyRevisionStatus();
if ($new_legacy_status == $old_legacy_status) {
return $xactions;
}

7
src/applications/differential/phid/DifferentialRevisionPHIDType.php
View file

@ -33,7 +33,6 @@ final class DifferentialRevisionPHIDType extends PhabricatorPHIDType {
$revision = $objects[$phid];
$title = $revision->getTitle();
$status = $revision->getStatus();
$monogram = $revision->getMonogram();
$uri = $revision->getURI();
@ -46,10 +45,8 @@ final class DifferentialRevisionPHIDType extends PhabricatorPHIDType {
$handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED);
}
$status = $revision->getStatus();
$icon = $revision->getStatusIcon($status);
$color = $revision->getStatusIconColor($status);
$icon = $revision->getStatusIcon();
$color = $revision->getStatusIconColor();
$name = $revision->getStatusDisplayName();
$handle

4
src/applications/differential/storage/DifferentialRevision.php
View file

@ -631,6 +631,10 @@ final class DifferentialRevision extends DifferentialDAO
return $this->getStatusObject()->getKey();
}
public function getLegacyRevisionStatus() {
return $this->getStatus();
}
public function isClosed() {
return $this->getStatusObject()->isClosedStatus();
}

4
src/applications/differential/xaction/DifferentialRevisionStatusTransaction.php
View file

@ -6,11 +6,11 @@ final class DifferentialRevisionStatusTransaction
const TRANSACTIONTYPE = 'differential.revision.status';
public function generateOldValue($object) {
return $object->getStatus();
return $object->getLegacyRevisionStatus();
}
public function applyInternalEffects($object, $value) {
$object->setStatus($value);
$object->setLegacyRevisionStatus($value);
}
public function getTitle() {