1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 21:02:41 +01:00

Add standard spacing around viewing panels

Summary: Just wraps them in some boxes in edit and standalone mode.

Test Plan: Tested 3 panels in edit and standalone mode.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9232
This commit is contained in:
Chad Little 2014-05-21 10:18:18 -07:00
parent 49c15a6d95
commit 53940e272f
2 changed files with 11 additions and 2 deletions

View file

@ -54,10 +54,14 @@ final class PhabricatorDashboardPanelRenderController
->addTextCrumb($panel->getMonogram(), '/'.$panel->getMonogram()) ->addTextCrumb($panel->getMonogram(), '/'.$panel->getMonogram())
->addTextCrumb(pht('Standalone View')); ->addTextCrumb(pht('Standalone View'));
$view = id(new PHUIBoxView())
->addMargin(PHUI::MARGIN_LARGE)
->appendChild($rendered_panel);
return $this->buildApplicationPage( return $this->buildApplicationPage(
array( array(
$crumbs, $crumbs,
$rendered_panel, $view,
), ),
array( array(
'title' => array(pht('Panel'), $panel->getName()), 'title' => array(pht('Panel'), $panel->getName()),

View file

@ -44,12 +44,17 @@ final class PhabricatorDashboardPanelViewController
->setParentPanelPHIDs(array()) ->setParentPanelPHIDs(array())
->renderPanel(); ->renderPanel();
$view = id(new PHUIBoxView())
->addMargin(PHUI::MARGIN_LARGE_LEFT)
->addMargin(PHUI::MARGIN_LARGE_RIGHT)
->appendChild($rendered_panel);
return $this->buildApplicationPage( return $this->buildApplicationPage(
array( array(
$crumbs, $crumbs,
$box, $box,
$timeline, $timeline,
$rendered_panel, $view,
), ),
array( array(
'title' => $title, 'title' => $title,