From 53d959a75540e532a2426d41d806d77e69fedbd0 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Fri, 20 Feb 2015 12:39:41 -0800
Subject: [PATCH] Tweak alert states in header a bit more

Summary: The sky blue colors in the alerts was problematic in other color headers (not black). Rather than hand tweak each color, just going with white seems best. There is also a small animation now, which you may or may not like. It is playful and enjoyable to me at least.

Test Plan: Tested various header colors with and without alert notifications.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11838
---
 resources/celerity/map.php                       |  6 +++---
 src/view/page/menu/PhabricatorMainMenuView.php   |  4 ++--
 .../rsrc/css/application/base/main-menu-view.css | 16 ++++++++--------
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 517be1d0d3..b31152a833 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => 'a605a99b',
+    'core.pkg.css' => 'aba1dfdf',
     'core.pkg.js' => '23d653bb',
     'darkconsole.pkg.js' => '8ab24e01',
     'differential.pkg.css' => '380f07e5',
@@ -35,7 +35,7 @@ return array(
     'rsrc/css/aphront/typeahead.css' => '0e403212',
     'rsrc/css/application/almanac/almanac.css' => 'dbb9b3af',
     'rsrc/css/application/auth/auth.css' => '1e655982',
-    'rsrc/css/application/base/main-menu-view.css' => 'c32b228a',
+    'rsrc/css/application/base/main-menu-view.css' => '8acd22bd',
     'rsrc/css/application/base/notification-menu.css' => '6aa0a74b',
     'rsrc/css/application/base/phabricator-application-launch-view.css' => '16ca323f',
     'rsrc/css/application/base/standard-page-view.css' => '60d0df9a',
@@ -729,7 +729,7 @@ return array(
     'phabricator-hovercard-view-css' => '893f4783',
     'phabricator-keyboard-shortcut' => '1ae869f2',
     'phabricator-keyboard-shortcut-manager' => 'c1700f6f',
-    'phabricator-main-menu-view' => 'c32b228a',
+    'phabricator-main-menu-view' => '8acd22bd',
     'phabricator-nav-view-css' => '7aeaf435',
     'phabricator-notification' => '0c6946e7',
     'phabricator-notification-css' => '9c279160',
diff --git a/src/view/page/menu/PhabricatorMainMenuView.php b/src/view/page/menu/PhabricatorMainMenuView.php
index 6919212381..43ead0c31f 100644
--- a/src/view/page/menu/PhabricatorMainMenuView.php
+++ b/src/view/page/menu/PhabricatorMainMenuView.php
@@ -144,7 +144,7 @@ final class PhabricatorMainMenuView extends AphrontView {
         'meta'  => array(
           'map' => array(
             $header_id => 'phabricator-application-menu-expanded',
-            $button_id => 'sky',
+            $button_id => 'white',
           ),
         ),
       ),
@@ -207,7 +207,7 @@ final class PhabricatorMainMenuView extends AphrontView {
         'meta'  => array(
           'map' => array(
             $header_id => 'phabricator-search-menu-expanded',
-            $button_id => 'sky',
+            $button_id => 'white',
           ),
         ),
       ),
diff --git a/webroot/rsrc/css/application/base/main-menu-view.css b/webroot/rsrc/css/application/base/main-menu-view.css
index c33d0da7fc..03c8cf7e69 100644
--- a/webroot/rsrc/css/application/base/main-menu-view.css
+++ b/webroot/rsrc/css/application/base/main-menu-view.css
@@ -281,18 +281,19 @@
 }
 
 .alert-notifications .phui-icon-view {
-  color: rgba(200,200,200, .5);
+  color: rgba(200,200,200, .4);
+  text-shadow: 0px -1px 0px rgba(0, 0, 0, 0.1);
+}
+
+.alert-notifications:hover {
+  margin-top: -1px;
+  transition-duration: .1s;
 }
 
 .alert-notifications:hover .phui-icon-view {
   color: #fff;
 }
 
-.alert-unread:hover .phabricator-main-menu-alert-icon.phui-icon-view,
-.message-unread:hover .phabricator-main-menu-message-icon.phui-icon-view {
-  color: {$sky};
-}
-
 .phabricator-main-menu-alert-icon,
 .phabricator-main-menu-message-icon {
   width: 18px;
@@ -327,7 +328,7 @@
 
 .alert-unread .phabricator-main-menu-alert-icon,
 .message-unread .phabricator-main-menu-message-icon  {
-  color: {$sky};
+  color: #fff;
 }
 
 .alert-unread .phabricator-main-menu-alert-count,
@@ -449,7 +450,6 @@
  .core-menu-item.phui-list-item-view:hover {
   background-color: rgba(0,0,0,.33);
   border-radius: 3px;
-  color: #fff;
 }
 
 .device-desktop .phabricator-application-menu .phui-list-item-view {