revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 05:12:41 +01:00
Code Issues Releases Wiki Activity

Slightly reduce the cost of resolving refs

Browse source 
Summary: Ref T2683. By resolving the stable name earlier, we can save a resolve when viewing branch heads. This is ~100ms in Mercurial, and roughly 25% of page weight. It's less bad in Git.

Test Plan: Saw page cost go down in "Services" tab, particularly for Mercurial browse views.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T2683

Differential Revision: https://secure.phabricator.com/D9048
This commit is contained in:
epriestley 2014-05-10 17:43:43 -07:00
parent e13369d208
commit 53e9df8a02
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diffusion/controller/DiffusionBrowseMainController.php
View file

@ -19,7 +19,7 @@ final class DiffusionBrowseMainController extends DiffusionBrowseController {
'diffusion.browsequery', 'diffusion.browsequery',
array( array(
'path' => $drequest->getPath(), 'path' => $drequest->getPath(),
'commit' => $drequest->getCommit(), 'commit' => $drequest->getStableCommitName(),
))); )));
$reason = $results->getReasonForEmptyResultSet(); $reason = $results->getReasonForEmptyResultSet();
$is_file = ($reason == DiffusionBrowseResultSet::REASON_IS_FILE); $is_file = ($reason == DiffusionBrowseResultSet::REASON_IS_FILE);