Merge branch 'master' into redesign-2015

resources/celerity/map.php

@@ -114,7 +114,7 @@ return array(
     'rsrc/css/diviner/diviner-shared.css' => '38813222',
     'rsrc/css/font/font-awesome.css' => 'e2e712fe',
     'rsrc/css/font/font-lato.css' => '5f05d817',
-    'rsrc/css/font/font-slabo.css' => '7a85ea13',
+    'rsrc/css/font/font-slabo.css' => '1f520937',
     'rsrc/css/font/phui-font-icon-base.css' => '3dad2ae3',
     'rsrc/css/layout/phabricator-filetree-view.css' => 'fccf9f82',
     'rsrc/css/layout/phabricator-hovercard-view.css' => '0d665853',
@@ -370,10 +370,10 @@ return array(
     'rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js' => 'e5822781',
     'rsrc/js/application/files/behavior-icon-composer.js' => '8ef9ab58',
     'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888',
-    'rsrc/js/application/herald/HeraldRuleEditor.js' => '271ffdd7',
+    'rsrc/js/application/herald/HeraldRuleEditor.js' => 'b2cae298',
     'rsrc/js/application/herald/PathTypeahead.js' => 'f7fc67ec',
     'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3',
-    'rsrc/js/application/maniphest/behavior-batch-editor.js' => 'f5d1233b',
+    'rsrc/js/application/maniphest/behavior-batch-editor.js' => '782ab6e7',
     'rsrc/js/application/maniphest/behavior-batch-selector.js' => '7b98d7c5',
     'rsrc/js/application/maniphest/behavior-line-chart.js' => '88f0c5b3',
     'rsrc/js/application/maniphest/behavior-list-edit.js' => 'a9f88de2',
@@ -390,7 +390,7 @@ return array(
     'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => '3f5d6dbf',
     'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'fc91ab6c',
     'rsrc/js/application/phortune/phortune-credit-card-form.js' => '2290aeef',
-    'rsrc/js/application/policy/behavior-policy-control.js' => '9a340b3d',
+    'rsrc/js/application/policy/behavior-policy-control.js' => '7d470398',
     'rsrc/js/application/policy/behavior-policy-rule-editor.js' => '5e9f347c',
     'rsrc/js/application/ponder/behavior-votebox.js' => '4e9b766b',
     'rsrc/js/application/projects/behavior-project-boards.js' => 'ba4fa35c',
@@ -522,11 +522,11 @@ return array(
     'diviner-shared-css' => '38813222',
     'font-fontawesome' => 'e2e712fe',
     'font-lato' => '5f05d817',
-    'font-slabo' => '7a85ea13',
+    'font-slabo' => '1f520937',
     'global-drag-and-drop-css' => '697324ad',
     'harbormaster-css' => '49d64eb4',
     'herald-css' => '826075fa',
-    'herald-rule-editor' => '271ffdd7',
+    'herald-rule-editor' => 'b2cae298',
     'herald-test-css' => '778b008e',
     'inline-comment-summary-css' => '51efda3a',
     'javelin-aphlict' => '5359e785',
@@ -585,7 +585,7 @@ return array(
     'javelin-behavior-lightbox-attachments' => 'f8ba29d7',
     'javelin-behavior-line-chart' => '88f0c5b3',
     'javelin-behavior-load-blame' => '42126667',
-    'javelin-behavior-maniphest-batch-editor' => 'f5d1233b',
+    'javelin-behavior-maniphest-batch-editor' => '782ab6e7',
     'javelin-behavior-maniphest-batch-selector' => '7b98d7c5',
     'javelin-behavior-maniphest-list-editor' => 'a9f88de2',
     'javelin-behavior-maniphest-subpriority-editor' => '84845b5b',
@@ -622,7 +622,7 @@ return array(
     'javelin-behavior-pholio-mock-view' => 'fbe497e7',
     'javelin-behavior-phui-dropdown-menu' => '54733475',
     'javelin-behavior-phui-object-box-tabs' => '2bfa2836',
-    'javelin-behavior-policy-control' => '9a340b3d',
+    'javelin-behavior-policy-control' => '7d470398',
     'javelin-behavior-policy-rule-editor' => '5e9f347c',
     'javelin-behavior-ponder-votebox' => '4e9b766b',
     'javelin-behavior-project-boards' => 'ba4fa35c',
@@ -973,6 +973,9 @@ return array(
       'javelin-dom',
       'javelin-reactor-dom',
     ),
+    '1f520937' => array(
+      'phui-fontkit-css',
+    ),
     '2035b9cb' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1010,15 +1013,6 @@ return array(
       'phabricator-drag-and-drop-file-upload',
       'phabricator-draggable-list',
     ),
-    '271ffdd7' => array(
-      'multirow-row-manager',
-      'javelin-install',
-      'javelin-util',
-      'javelin-dom',
-      'javelin-stratcom',
-      'javelin-json',
-      'phabricator-prefab',
-    ),
     '2818f5ce' => array(
       'javelin-install',
       'javelin-util',
@@ -1414,6 +1408,14 @@ return array(
       'javelin-util',
       'phabricator-busy',
     ),
+    '782ab6e7' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-util',
+      'phabricator-prefab',
+      'multirow-row-manager',
+      'javelin-json',
+    ),
     '7927a7d3' => array(
       'javelin-behavior',
       'javelin-quicksand',
@@ -1422,9 +1424,6 @@ return array(
       'owners-path-editor',
       'javelin-behavior',
     ),
-    '7a85ea13' => array(
-      'phui-fontkit-css',
-    ),
     '7b98d7c5' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1437,6 +1436,15 @@ return array(
       'javelin-request',
       'javelin-router',
     ),
+    '7d470398' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-util',
+      'phuix-dropdown-menu',
+      'phuix-action-list-view',
+      'phuix-action-view',
+      'javelin-workflow',
+    ),
     '7e41274a' => array(
       'javelin-install',
     ),
@@ -1582,15 +1590,6 @@ return array(
       'javelin-dom',
       'javelin-reactor-dom',
     ),
-    '9a340b3d' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-util',
-      'phuix-dropdown-menu',
-      'phuix-action-list-view',
-      'phuix-action-view',
-      'javelin-workflow',
-    ),
     '9f36c42d' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1707,6 +1706,15 @@ return array(
       'javelin-uri',
       'javelin-request',
     ),
+    'b2cae298' => array(
+      'multirow-row-manager',
+      'javelin-install',
+      'javelin-util',
+      'javelin-dom',
+      'javelin-stratcom',
+      'javelin-json',
+      'phabricator-prefab',
+    ),
     'b3a4b884' => array(
       'javelin-behavior',
       'phabricator-prefab',
@@ -1970,14 +1978,6 @@ return array(
       'javelin-request',
       'phabricator-keyboard-shortcut',
     ),
-    'f5d1233b' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-util',
-      'phabricator-prefab',
-      'multirow-row-manager',
-      'javelin-json',
-    ),
     'f6555212' => array(
       'javelin-install',
       'javelin-reactornode',

resources/sql/autopatches/20150609.spaces.1.pholio.sql

@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_pholio.pholio_mock
+  ADD spacePHID VARBINARY(64);

resources/sql/autopatches/20150609.spaces.2.maniphest.sql

@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_maniphest.maniphest_task
+  ADD spacePHID VARBINARY(64);

resources/sql/autopatches/20150610.spaces.1.desc.sql

@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_spaces.spaces_namespace
+  ADD description LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL;

resources/sql/autopatches/20150610.spaces.2.edge.sql

@@ -0,0 +1,16 @@
+CREATE TABLE {$NAMESPACE}_spaces.edge (
+  src VARBINARY(64) NOT NULL,
+  type INT UNSIGNED NOT NULL,
+  dst VARBINARY(64) NOT NULL,
+  dateCreated INT UNSIGNED NOT NULL,
+  seq INT UNSIGNED NOT NULL,
+  dataID INT UNSIGNED,
+  PRIMARY KEY (src, type, dst),
+  KEY `src` (src, type, dateCreated, seq),
+  UNIQUE KEY `key_dst` (dst, type, src)
+) ENGINE=InnoDB, COLLATE {$COLLATE_TEXT};
+
+CREATE TABLE {$NAMESPACE}_spaces.edgedata (
+  id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT,
+  data LONGTEXT NOT NULL COLLATE {$COLLATE_TEXT}
+) ENGINE=InnoDB, COLLATE {$COLLATE_TEXT};

resources/sql/autopatches/20150610.spaces.3.archive.sql

@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_spaces.spaces_namespace
+  ADD isArchived BOOL NOT NULL;

resources/sql/autopatches/20150611.spaces.1.mailxaction.sql

@@ -0,0 +1,19 @@
+CREATE TABLE {$NAMESPACE}_metamta.metamta_applicationemailtransaction (
+  id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
+  phid VARBINARY(64) NOT NULL,
+  authorPHID VARBINARY(64) NOT NULL,
+  objectPHID VARBINARY(64) NOT NULL,
+  viewPolicy VARBINARY(64) NOT NULL,
+  editPolicy VARBINARY(64) NOT NULL,
+  commentPHID VARBINARY(64) DEFAULT NULL,
+  commentVersion INT UNSIGNED NOT NULL,
+  transactionType VARCHAR(32) COLLATE {$COLLATE_TEXT} NOT NULL,
+  oldValue LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  newValue LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  contentSource LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  metadata LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL,
+  dateCreated INT UNSIGNED NOT NULL,
+  dateModified INT UNSIGNED NOT NULL,
+  UNIQUE KEY `key_phid` (`phid`),
+  KEY `key_object` (`objectPHID`)
+) ENGINE=InnoDB, COLLATE {$COLLATE_TEXT};

resources/sql/autopatches/20150611.spaces.2.appmail.sql

@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_metamta.metamta_applicationemail
+  ADD spacePHID VARBINARY(64);

resources/sql/patches/20131121.repocredentials.2.mig.php

@@ -26,7 +26,7 @@ foreach (new LiskMigrationIterator($table) as $repository) {
   if ($proto == 'http' || $proto == 'https' || $proto == 'svn') {
     $username = $repository->getDetail('http-login');
     $secret = $repository->getDetail('http-pass');
-    $type = PassphraseCredentialTypePassword::CREDENTIAL_TYPE;
+    $type = PassphrasePasswordCredentialType::CREDENTIAL_TYPE;
   } else {
     $username = $repository->getDetail('ssh-login');
     if (!$username) {
@@ -42,10 +42,10 @@ foreach (new LiskMigrationIterator($table) as $repository) {
     $file = $repository->getDetail('ssh-keyfile');
     if ($file) {
       $secret = $file;
-      $type = PassphraseCredentialTypeSSHPrivateKeyFile::CREDENTIAL_TYPE;
+      $type = PassphraseSSHPrivateKeyFileCredentialType::CREDENTIAL_TYPE;
     } else {
       $secret = $repository->getDetail('ssh-key');
-      $type = PassphraseCredentialTypeSSHPrivateKeyText::CREDENTIAL_TYPE;
+      $type = PassphraseSSHPrivateKeyTextCredentialType::CREDENTIAL_TYPE;
     }
   }
 

src/aphront/AphrontRequest.php

@@ -5,7 +5,7 @@
  * @task cookie   Managing Cookies
  * @task cluster  Working With a Phabricator Cluster
  */
-final class AphrontRequest {
+final class AphrontRequest extends Phobject {
 
   // NOTE: These magic request-type parameters are automatically included in
   // certain requests (e.g., by phabricator_form(), JX.Request,
@@ -27,6 +27,7 @@ final class AphrontRequest {
   private $user;
   private $applicationConfiguration;
   private $uriData;
+  private $cookiePrefix;
 
   public function __construct($host, $path) {
     $this->host = $host;

src/aphront/AphrontURIMapper.php

@@ -1,6 +1,6 @@
 <?php
 
-final class AphrontURIMapper {
+final class AphrontURIMapper extends Phobject {
 
   private $map;
 

src/aphront/configuration/AphrontApplicationConfiguration.php

@@ -3,7 +3,7 @@
 /**
  * @task  routing URI Routing
  */
-abstract class AphrontApplicationConfiguration {
+abstract class AphrontApplicationConfiguration extends Phobject {
 
   private $request;
   private $host;

src/aphront/response/AphrontPlainTextResponse.php

@@ -2,6 +2,8 @@
 
 final class AphrontPlainTextResponse extends AphrontResponse {
 
+  private $content;
+
   public function setContent($content) {
     $this->content = $content;
     return $this;

src/aphront/response/AphrontResponse.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class AphrontResponse {
+abstract class AphrontResponse extends Phobject {
 
   private $request;
   private $cacheable = false;

src/aphront/sink/AphrontHTTPSink.php

@@ -11,7 +11,7 @@
  * @task write  Writing Response Components
  * @task emit   Emitting the Response
  */
-abstract class AphrontHTTPSink {
+abstract class AphrontHTTPSink extends Phobject {
 
 
 /* -(  Writing Response Components  )---------------------------------------- */

src/applications/almanac/servicetype/__tests__/AlmanacServiceTypeTestCase.php

@@ -0,0 +1,10 @@
+<?php
+
+final class AlmanacServiceTypeTestCase extends PhabricatorTestCase {
+
+  public function testGetAllServiceTypes() {
+    AlmanacServiceType::getAllServiceTypes();
+    $this->assertTrue(true);
+  }
+
+}

src/applications/aphlict/query/AphlictDropdownDataQuery.php

@@ -1,6 +1,6 @@
 <?php
 
-final class AphlictDropdownDataQuery {
+final class AphlictDropdownDataQuery extends Phobject {
 
   private $viewer;
   private $notificationData;

src/applications/audit/constants/PhabricatorAuditActionConstants.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorAuditActionConstants {
+final class PhabricatorAuditActionConstants extends Phobject {
 
   const CONCERN   = 'concern';
   const ACCEPT    = 'accept';

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorAuditCommitStatusConstants {
+final class PhabricatorAuditCommitStatusConstants extends Phobject {
 
   const NONE                = 0;
   const NEEDS_AUDIT         = 1;

src/applications/audit/constants/PhabricatorAuditStatusConstants.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorAuditStatusConstants {
+final class PhabricatorAuditStatusConstants extends Phobject {
 
   const NONE                    = '';
   const AUDIT_NOT_REQUIRED      = 'audit-not-required';

src/applications/audit/storage/PhabricatorAuditInlineComment.php

@@ -1,6 +1,7 @@
 <?php
 
 final class PhabricatorAuditInlineComment
+  extends Phobject
   implements PhabricatorInlineCommentInterface {
 
   private $proxy;

src/applications/auth/controller/PhabricatorAuthStartController.php

@@ -71,7 +71,7 @@ final class PhabricatorAuthStartController
           'This Phabricator install is not configured with any enabled '.
           'authentication providers which can be used to log in. If you '.
           'have accidentally locked yourself out by disabling all providers, '.
-          'you can use `%s` to recover access to an administrative account.'.
+          'you can use `%s` to recover access to an administrative account.',
           'phabricator/bin/auth recover <username>'));
     }
 

src/applications/auth/data/PhabricatorAuthHighSecurityToken.php

@@ -1,3 +1,3 @@
 <?php
 
-final class PhabricatorAuthHighSecurityToken {}
+final class PhabricatorAuthHighSecurityToken extends Phobject {}

src/applications/auth/factor/__tests__/PhabricatorAuthFactorTestCase.php

@@ -0,0 +1,10 @@
+<?php
+
+final class PhabricatorAuthFactorTestCase extends PhabricatorTestCase {
+
+  public function testGetAllFactors() {
+    PhabricatorAuthFactor::getAllFactors();
+    $this->assertTrue(true);
+  }
+
+}

src/applications/auth/provider/PhabricatorAuthProvider.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class PhabricatorAuthProvider {
+abstract class PhabricatorAuthProvider extends Phobject {
 
   private $providerConfig;
 

src/applications/base/PhabricatorApplication.php

@@ -8,7 +8,9 @@
  * @task  fact  Fact Integration
  * @task  meta  Application Management
  */
-abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
+abstract class PhabricatorApplication
+  extends Phobject
+  implements PhabricatorPolicyInterface {
 
   const MAX_STATUS_ITEMS      = 100;
 
@@ -17,7 +19,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
   const GROUP_ADMIN           = 'admin';
   const GROUP_DEVELOPER       = 'developer';
 
-  public static function getApplicationGroups() {
+  final public static function getApplicationGroups() {
     return array(
       self::GROUP_CORE          => pht('Core Applications'),
       self::GROUP_UTILITIES     => pht('Utilities'),
@@ -35,7 +37,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     return pht('%s Application', $this->getName());
   }
 
-  public function isInstalled() {
+  final public function isInstalled() {
     if (!$this->canUninstall()) {
       return true;
     }
@@ -133,7 +135,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     return true;
   }
 
-  public function getPHID() {
+  final public function getPHID() {
     return 'PHID-APPS-'.get_class($this);
   }
 
@@ -145,7 +147,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     return null;
   }
 
-  public function getApplicationURI($path = '') {
+  final public function getApplicationURI($path = '') {
     return $this->getBaseURI().ltrim($path, '/');
   }
 
@@ -169,7 +171,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     return null;
   }
 
-  public function getHelpMenuItems(PhabricatorUser $viewer) {
+  final public function getHelpMenuItems(PhabricatorUser $viewer) {
     $items = array();
 
     $articles = $this->getHelpDocumentationArticles($viewer);
@@ -249,7 +251,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     return false;
   }
 
-  protected function getInboundEmailSupportLink() {
+  final protected function getInboundEmailSupportLink() {
     return PhabricatorEnv::getDocLink('Configuring Inbound Email');
   }
 
@@ -286,7 +288,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
    * @return string
    * @task ui
    */
-  public static function formatStatusCount(
+  final public static function formatStatusCount(
     $count,
     $limit_string = '%s',
     $base_string = '%d') {
@@ -359,7 +361,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
 /* -(  Application Management  )--------------------------------------------- */
 
 
-  public static function getByClass($class_name) {
+  final public static function getByClass($class_name) {
     $selected = null;
     $applications = self::getAllApplications();
 
@@ -377,7 +379,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     return $selected;
   }
 
-  public static function getAllApplications() {
+  final public static function getAllApplications() {
     static $applications;
 
     if ($applications === null) {
@@ -401,7 +403,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     return $applications;
   }
 
-  public static function getAllInstalledApplications() {
+  final public static function getAllInstalledApplications() {
     $all_applications = self::getAllApplications();
     $apps = array();
     foreach ($all_applications as $app) {
@@ -426,7 +428,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
    * @return bool   True if the class is installed.
    * @task meta
    */
-  public static function isClassInstalled($class) {
+  final public static function isClassInstalled($class) {
     return self::getByClass($class)->isInstalled();
   }
 
@@ -443,7 +445,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
    * @return bool True if the class is installed for the viewer.
    * @task meta
    */
-  public static function isClassInstalledForViewer(
+  final public static function isClassInstalledForViewer(
     $class,
     PhabricatorUser $viewer) {
 
@@ -502,7 +504,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     return array();
   }
 
-  private function getCustomPolicySetting($capability) {
+  final private function getCustomPolicySetting($capability) {
     if (!$this->isCapabilityEditable($capability)) {
       return null;
     }
@@ -528,7 +530,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
   }
 
 
-  private function getCustomCapabilitySpecification($capability) {
+  final private function getCustomCapabilitySpecification($capability) {
     $custom = $this->getCustomCapabilities();
     if (!isset($custom[$capability])) {
       throw new Exception(pht("Unknown capability '%s'!", $capability));
@@ -536,7 +538,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     return $custom[$capability];
   }
 
-  public function getCapabilityLabel($capability) {
+  final public function getCapabilityLabel($capability) {
     switch ($capability) {
       case PhabricatorPolicyCapability::CAN_VIEW:
         return pht('Can Use Application');
@@ -552,7 +554,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     return null;
   }
 
-  public function isCapabilityEditable($capability) {
+  final public function isCapabilityEditable($capability) {
     switch ($capability) {
       case PhabricatorPolicyCapability::CAN_VIEW:
         return $this->canUninstall();
@@ -564,7 +566,7 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     }
   }
 
-  public function getCapabilityCaption($capability) {
+  final public function getCapabilityCaption($capability) {
     switch ($capability) {
       case PhabricatorPolicyCapability::CAN_VIEW:
         if (!$this->canUninstall()) {
@@ -582,6 +584,17 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
     }
   }
 
+  final public function getCapabilityTemplatePHIDType($capability) {
+    switch ($capability) {
+      case PhabricatorPolicyCapability::CAN_VIEW:
+      case PhabricatorPolicyCapability::CAN_EDIT:
+        return null;
+    }
+
+    $spec = $this->getCustomCapabilitySpecification($capability);
+    return idx($spec, 'template');
+  }
+
   public function getApplicationSearchDocumentTypes() {
     return array();
   }

src/applications/base/__tests__/PhabricatorApplicationTestCase.php

@@ -0,0 +1,10 @@
+<?php
+
+final class PhabricatorApplicationTestCase extends PhabricatorTestCase {
+
+  public function testGetAllApplications() {
+    PhabricatorApplication::getAllApplications();
+    $this->assertTrue(true);
+  }
+
+}

src/applications/cache/PhabricatorCaches.php

@@ -7,7 +7,7 @@
  * @task setup      Setup Cache
  * @task compress   Compression
  */
-final class PhabricatorCaches {
+final class PhabricatorCaches extends Phobject {
 
   private static $requestCache;
 

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

@@ -17,7 +17,7 @@ final class PhabricatorCalendarEventEditController
     $viewer = $request->getViewer();
     $user_phid = $viewer->getPHID();
     $error_name = true;
-    $error_recurrence_end_date = true;
+    $error_recurrence_end_date = null;
     $error_start_date = true;
     $error_end_date = true;
     $validation_exception = null;
@@ -336,8 +336,7 @@ final class PhabricatorCalendarEventEditController
         ->setID($recurrence_end_date_id)
         ->setIsTimeDisabled(true)
         ->setIsDisabled($recurrence_end_date_value->isDisabled())
-        ->setAllowNull(true)
+        ->setAllowNull(true);
-        ->isRequired(false);
 
       $recurrence_frequency_select = id(new AphrontFormSelectControl())
         ->setName('frequency')

src/applications/calendar/storage/PhabricatorCalendarEvent.php

@@ -316,7 +316,7 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
       case 'monthly':
         return 'month';
       case 'yearly':
-        return 'yearly';
+        return 'year';
       default:
         return 'day';
     }

src/applications/calendar/util/CalendarTimeUtil.php

@@ -10,7 +10,7 @@
  * a Sunday -> Saturday list, whilest the profile view shows a more simple
  * seven day rolling list of events.
  */
-final class CalendarTimeUtil {
+final class CalendarTimeUtil extends Phobject {
 
   public static function getCalendarEventEpochs(
     PhabricatorUser $user,

src/applications/celerity/CelerityAPI.php

@@ -4,7 +4,7 @@
  * Indirection layer which provisions for a terrifying future where we need to
  * build multiple resource responses per page.
  */
-final class CelerityAPI {
+final class CelerityAPI extends Phobject {
 
   private static $response;
 

src/applications/celerity/CelerityResourceMap.php

@@ -6,7 +6,7 @@
  * not need to invoke it directly; instead, you call higher-level Celerity APIs
  * and it uses the resource map to satisfy your requests.
  */
-final class CelerityResourceMap {
+final class CelerityResourceMap extends Phobject {
 
   private static $instances = array();
 
@@ -16,6 +16,7 @@ final class CelerityResourceMap {
   private $packageMap;
   private $nameMap;
   private $hashMap;
+  private $componentMap;
 
   public function __construct(CelerityResources $resources) {
     $this->resources = $resources;

src/applications/celerity/CelerityResourceMapGenerator.php

@@ -1,6 +1,6 @@
 <?php
 
-final class CelerityResourceMapGenerator {
+final class CelerityResourceMapGenerator extends Phobject {
 
   private $debug = false;
   private $resources;

src/applications/celerity/CelerityResourceTransformer.php

@@ -1,6 +1,6 @@
 <?php
 
-final class CelerityResourceTransformer {
+final class CelerityResourceTransformer extends Phobject {
 
   private $minify;
   private $rawURIMap;

src/applications/celerity/CeleritySpriteGenerator.php

@@ -1,6 +1,6 @@
 <?php
 
-final class CeleritySpriteGenerator {
+final class CeleritySpriteGenerator extends Phobject {
 
   public function buildMenuSheet() {
     $sprites = array();

src/applications/celerity/CelerityStaticResourceResponse.php

@@ -5,7 +5,7 @@
  * @{function:require_celerity_resource}, and then builds appropriate HTML or
  * Ajax responses.
  */
-final class CelerityStaticResourceResponse {
+final class CelerityStaticResourceResponse extends Phobject {
 
   private $symbols = array();
   private $needsResolve = true;

src/applications/celerity/resources/CelerityPhysicalResources.php

@@ -21,6 +21,7 @@ abstract class CelerityPhysicalResources extends CelerityResources {
 
   public static function getAll() {
     static $resources_map;
+
     if ($resources_map === null) {
       $resources_map = array();
 

src/applications/celerity/resources/CelerityResources.php

@@ -3,7 +3,7 @@
 /**
  * Defines the location of static resources.
  */
-abstract class CelerityResources {
+abstract class CelerityResources extends Phobject {
 
   private $map;
 

src/applications/celerity/resources/__tests__/CelerityPhysicalResourcesTestCase.php

@@ -0,0 +1,10 @@
+<?php
+
+final class CelerityPhysicalResourcesTestCase extends PhabricatorTestCase {
+
+  public function testGetAll() {
+    CelerityPhysicalResources::getAll();
+    $this->assertTrue(true);
+  }
+
+}

src/applications/conduit/call/ConduitCall.php

@@ -8,9 +8,10 @@
  *   $result = $call->execute();
  *
  */
-final class ConduitCall {
+final class ConduitCall extends Phobject {
 
   private $method;
+  private $handler;
   private $request;
   private $user;
 

src/applications/conduit/method/ConduitAPIMethod.php

@@ -115,7 +115,7 @@ abstract class ConduitAPIMethod
     return head(explode('.', $this->getAPIMethodName(), 2));
   }
 
-  public static function getConduitMethod($method_name) {
+  public static function loadAllConduitMethods() {
     static $method_map = null;
 
     if ($method_map === null) {
@@ -143,6 +143,11 @@ abstract class ConduitAPIMethod
       }
     }
 
+    return $method_map;
+  }
+
+  public static function getConduitMethod($method_name) {
+    $method_map = self::loadAllConduitMethods();
     return idx($method_map, $method_name);
   }
 

src/applications/conduit/method/__tests__/ConduitAPIMethodTestCase.php

@@ -0,0 +1,10 @@
+<?php
+
+final class ConduitAPIMethodTestCase extends PhabricatorTestCase {
+
+  public function testLoadAllConduitMethods() {
+    ConduitAPIMethod::loadAllConduitMethods();
+    $this->assertTrue(true);
+  }
+
+}

src/applications/conduit/protocol/ConduitAPIRequest.php

@@ -1,6 +1,6 @@
 <?php
 
-final class ConduitAPIRequest {
+final class ConduitAPIRequest extends Phobject {
 
   protected $params;
   private $user;

src/applications/conduit/protocol/ConduitAPIResponse.php

@@ -1,6 +1,6 @@
 <?php
 
-final class ConduitAPIResponse {
+final class ConduitAPIResponse extends Phobject {
 
   private $result;
   private $errorCode;

src/applications/config/check/PhabricatorSetupCheck.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class PhabricatorSetupCheck {
+abstract class PhabricatorSetupCheck extends Phobject {
 
   private $issues;
 
@@ -111,7 +111,7 @@ abstract class PhabricatorSetupCheck {
     }
   }
 
-  final public static function runAllChecks() {
+  final public static function loadAllChecks() {
     $symbols = id(new PhutilSymbolLoader())
       ->setAncestorClass(__CLASS__)
       ->setConcreteOnly(true)
@@ -122,7 +122,11 @@ abstract class PhabricatorSetupCheck {
       $checks[] = newv($symbol['name'], array());
     }
 
-    $checks = msort($checks, 'getExecutionOrder');
+    return msort($checks, 'getExecutionOrder');
+  }
+
+  final public static function runAllChecks() {
+    $checks = self::loadAllChecks();
 
     $issues = array();
     foreach ($checks as $check) {

src/applications/config/check/__tests__/PhabricatorSetupCheckTestCase.php

@@ -0,0 +1,10 @@
+<?php
+
+final class PhabricatorSetupCheckTestCase extends PhabricatorTestCase {
+
+  public function testLoadAllChecks() {
+    PhabricatorSetupCheck::loadAllChecks();
+    $this->assertTrue(true);
+  }
+
+}

src/applications/config/custom/PhabricatorConfigOptionType.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class PhabricatorConfigOptionType {
+abstract class PhabricatorConfigOptionType extends Phobject {
 
   public function validateOption(PhabricatorConfigOption $option, $value) {
     return;

src/applications/config/issue/PhabricatorSetupIssue.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorSetupIssue {
+final class PhabricatorSetupIssue extends Phobject {
 
   private $issueKey;
   private $name;

src/applications/config/json/PhabricatorConfigJSON.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorConfigJSON {
+final class PhabricatorConfigJSON extends Phobject {
   /**
    * Properly format a JSON value.
    *

src/applications/conpherence/ConpherenceTransactionRenderer.php

@@ -1,6 +1,6 @@
 <?php
 
-final class ConpherenceTransactionRenderer {
+final class ConpherenceTransactionRenderer extends Phobject {
 
   public static function renderTransactions(
     PhabricatorUser $user,

src/applications/conpherence/constants/ConpherenceConstants.php

@@ -1,3 +1,3 @@
 <?php
 
-abstract class ConpherenceConstants {}
+abstract class ConpherenceConstants extends Phobject {}

src/applications/conpherence/policyrule/ConpherenceThreadMembersPolicyRule.php

@@ -0,0 +1,42 @@
+<?php
+
+final class ConpherenceThreadMembersPolicyRule
+  extends PhabricatorPolicyRule {
+
+  public function getObjectPolicyKey() {
+    return 'conpherence.members';
+  }
+
+  public function getObjectPolicyName() {
+    return pht('Thread Members');
+  }
+
+  public function getPolicyExplanation() {
+    return pht('Members of this thread can take this action.');
+  }
+
+  public function getRuleDescription() {
+    return pht('thread members');
+  }
+
+  public function canApplyToObject(PhabricatorPolicyInterface $object) {
+    return ($object instanceof ConpherenceThread);
+  }
+
+  public function applyRule(
+    PhabricatorUser $viewer,
+    $value,
+    PhabricatorPolicyInterface $object) {
+    $viewer_phid = $viewer->getPHID();
+    if (!$viewer_phid) {
+      return false;
+    }
+
+    return (bool)$object->getParticipantIfExists($viewer_phid);
+  }
+
+  public function getValueControlType() {
+    return self::CONTROL_TYPE_NONE;
+  }
+
+}

src/applications/console/core/DarkConsoleCore.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DarkConsoleCore {
+final class DarkConsoleCore extends Phobject {
 
   private $plugins = array();
   const STORAGE_VERSION = 1;

src/applications/console/plugin/DarkConsolePlugin.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class DarkConsolePlugin {
+abstract class DarkConsolePlugin extends Phobject {
 
   private $data;
   private $request;

src/applications/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DarkConsoleErrorLogPluginAPI {
+final class DarkConsoleErrorLogPluginAPI extends Phobject {
 
   private static $errors = array();
 

src/applications/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php

@@ -4,7 +4,7 @@
  * @phutil-external-symbol function xhprof_enable
  * @phutil-external-symbol function xhprof_disable
  */
-final class DarkConsoleXHProfPluginAPI {
+final class DarkConsoleXHProfPluginAPI extends Phobject {
 
   private static $profilerStarted;
   private static $profilerRunning;

src/applications/countdown/application/PhabricatorCountdownApplication.php

@@ -52,6 +52,7 @@ final class PhabricatorCountdownApplication extends PhabricatorApplication {
     return array(
       PhabricatorCountdownDefaultViewCapability::CAPABILITY => array(
         'caption' => pht('Default view policy for new countdowns.'),
+        'template' => PhabricatorCountdownCountdownPHIDType::TYPECONST,
       ),
     );
   }

src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorDashboardLayoutConfig {
+final class PhabricatorDashboardLayoutConfig extends Phobject {
 
   const MODE_FULL                = 'layout-mode-full';
   const MODE_HALF_AND_HALF       = 'layout-mode-half-and-half';

src/applications/differential/DifferentialGetWorkingCopy.php

@@ -4,7 +4,7 @@
  * Can't find a good place for this, so I'm putting it in the most notably
  * wrong place.
  */
-final class DifferentialGetWorkingCopy {
+final class DifferentialGetWorkingCopy extends Phobject {
 
   /**
    * Creates and/or cleans a workspace for the requested repo.

src/applications/differential/application/PhabricatorDifferentialApplication.php

@@ -186,6 +186,7 @@ final class PhabricatorDifferentialApplication extends PhabricatorApplication {
     return array(
       DifferentialDefaultViewCapability::CAPABILITY => array(
         'caption' => pht('Default view policy for newly created revisions.'),
+        'template' => DifferentialRevisionPHIDType::TYPECONST,
       ),
     );
   }

src/applications/differential/constants/DifferentialAction.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialAction {
+final class DifferentialAction extends Phobject {
 
   const ACTION_CLOSE          = 'commit';
   const ACTION_COMMENT        = 'none';

src/applications/differential/constants/DifferentialChangeType.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialChangeType {
+final class DifferentialChangeType extends Phobject {
 
   const TYPE_ADD        = 1;
   const TYPE_CHANGE     = 2;

src/applications/differential/constants/DifferentialLintStatus.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialLintStatus {
+final class DifferentialLintStatus extends Phobject {
 
   const LINT_NONE             = 0;
   const LINT_OKAY             = 1;

src/applications/differential/constants/DifferentialReviewerStatus.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialReviewerStatus {
+final class DifferentialReviewerStatus extends Phobject {
 
   const STATUS_BLOCKING = 'blocking';
   const STATUS_ADDED = 'added';

src/applications/differential/constants/DifferentialRevisionControlSystem.php

@@ -1,7 +1,7 @@
 <?php
 
 // TODO: Unify with similar Repository constants
-final class DifferentialRevisionControlSystem {
+final class DifferentialRevisionControlSystem extends Phobject {
 
   const SVN         = 'svn';
   const GIT         = 'git';

src/applications/differential/constants/DifferentialRevisionStatus.php

@@ -6,7 +6,7 @@
  * application.
  */
 
-final class DifferentialRevisionStatus {
+final class DifferentialRevisionStatus extends Phobject {
 
   const COLOR_STATUS_DEFAULT = 'status';
   const COLOR_STATUS_DARK = 'status-dark';

src/applications/differential/constants/DifferentialUnitStatus.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialUnitStatus {
+final class DifferentialUnitStatus extends Phobject {
 
   const UNIT_NONE             = 0;
   const UNIT_OKAY             = 1;

src/applications/differential/constants/DifferentialUnitTestResult.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialUnitTestResult {
+final class DifferentialUnitTestResult extends Phobject {
 
   const RESULT_PASS         = 'pass';
   const RESULT_FAIL         = 'fail';

src/applications/differential/landing/DifferentialLandingStrategy.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class DifferentialLandingStrategy {
+abstract class DifferentialLandingStrategy extends Phobject {
 
   abstract public function processLandRequest(
     AphrontRequest $request,

src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php

@@ -48,8 +48,6 @@ final class PhabricatorHunksManagementMigrateWorkflow
             new PhutilNumber($diff_len),
             sprintf('%.1f%%', 100 * ($diff_len / $old_len))));
       }
-
-      break;
     }
 
     if ($saw_any_rows) {

src/applications/differential/parser/DifferentialChangesetParser.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialChangesetParser {
+final class DifferentialChangesetParser extends Phobject {
 
   const HIGHLIGHT_BYTE_LIMIT = 262144;
 
@@ -55,6 +55,8 @@ final class DifferentialChangesetParser {
   private $rangeEnd;
   private $mask;
 
+  private $highlightEngine;
+
   public function setRange($start, $end) {
     $this->rangeStart = $start;
     $this->rangeEnd = $end;

src/applications/differential/parser/DifferentialCommitMessageParser.php

@@ -19,7 +19,7 @@
  * @task support  Support Methods
  * @task internal Internals
  */
-final class DifferentialCommitMessageParser {
+final class DifferentialCommitMessageParser extends Phobject {
 
   private $labelMap;
   private $titleKey;

src/applications/differential/parser/DifferentialHunkParser.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialHunkParser {
+final class DifferentialHunkParser extends Phobject {
 
   private $oldLines;
   private $newLines;

src/applications/differential/render/DifferentialChangesetRenderer.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class DifferentialChangesetRenderer {
+abstract class DifferentialChangesetRenderer extends Phobject {
 
   private $user;
   private $changeset;

src/applications/differential/render/DifferentialRawDiffRenderer.php

@@ -1,5 +1,6 @@
 <?php
-final class DifferentialRawDiffRenderer {
+
+final class DifferentialRawDiffRenderer extends Phobject {
 
   private $changesets;
   private $format = 'unified';

src/applications/differential/storage/DifferentialInlineComment.php

@@ -1,6 +1,7 @@
 <?php
 
 final class DifferentialInlineComment
+  extends Phobject
   implements PhabricatorInlineCommentInterface {
 
   private $proxy;

src/applications/differential/storage/DifferentialReviewer.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialReviewer {
+final class DifferentialReviewer extends Phobject {
 
   private $reviewerPHID;
   private $status;

src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialChangesetFileTreeSideNavBuilder {
+final class DifferentialChangesetFileTreeSideNavBuilder extends Phobject {
 
   private $title;
   private $baseURI;

src/applications/diffusion/DiffusionLintSaveRunner.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionLintSaveRunner {
+final class DiffusionLintSaveRunner extends Phobject {
   private $arc = 'arc';
   private $severity = ArcanistLintSeverity::SEVERITY_ADVICE;
   private $all = false;

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

@@ -140,11 +140,16 @@ final class PhabricatorDiffusionApplication extends PhabricatorApplication {
 
   protected function getCustomCapabilities() {
     return array(
-      DiffusionDefaultViewCapability::CAPABILITY => array(),
+      DiffusionDefaultViewCapability::CAPABILITY => array(
+        'template' => PhabricatorRepositoryRepositoryPHIDType::TYPECONST,
+      ),
       DiffusionDefaultEditCapability::CAPABILITY => array(
         'default' => PhabricatorPolicies::POLICY_ADMIN,
+        'template' => PhabricatorRepositoryRepositoryPHIDType::TYPECONST,
+      ),
+      DiffusionDefaultPushCapability::CAPABILITY => array(
+        'template' => PhabricatorRepositoryRepositoryPHIDType::TYPECONST,
       ),
-      DiffusionDefaultPushCapability::CAPABILITY => array(),
       DiffusionCreateRepositoriesCapability::CAPABILITY => array(
         'default' => PhabricatorPolicies::POLICY_ADMIN,
       ),

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

@@ -591,8 +591,8 @@ final class DiffusionRepositoryCreateController
     if ($this->isSSHProtocol($proto)) {
       $c_credential->setLabel(pht('SSH Key'));
       $c_credential->setCredentialType(
-        PassphraseCredentialTypeSSHPrivateKeyText::CREDENTIAL_TYPE);
+        PassphraseSSHPrivateKeyTextCredentialType::CREDENTIAL_TYPE);
-      $provides_type = PassphraseCredentialTypeSSHPrivateKey::PROVIDES_TYPE;
+      $provides_type = PassphraseSSHPrivateKeyCredentialType::PROVIDES_TYPE;
 
       $page->addRemarkupInstructions(
         pht(
@@ -607,8 +607,8 @@ final class DiffusionRepositoryCreateController
       $c_credential->setLabel(pht('Password'));
       $c_credential->setAllowNull(true);
       $c_credential->setCredentialType(
-        PassphraseCredentialTypePassword::CREDENTIAL_TYPE);
+        PassphrasePasswordCredentialType::CREDENTIAL_TYPE);
-      $provides_type = PassphraseCredentialTypePassword::PROVIDES_TYPE;
+      $provides_type = PassphrasePasswordCredentialType::PROVIDES_TYPE;
 
       $page->addRemarkupInstructions(
         pht(
@@ -663,7 +663,7 @@ final class DiffusionRepositoryCreateController
           pht('You must choose an SSH credential to connect over SSH.'));
       }
 
-      $ssh_type = PassphraseCredentialTypeSSHPrivateKey::PROVIDES_TYPE;
+      $ssh_type = PassphraseSSHPrivateKeyCredentialType::PROVIDES_TYPE;
       if ($credential->getProvidesType() !== $ssh_type) {
         $c_credential->setError(pht('Invalid'));
         $page->addPageError(
@@ -674,7 +674,7 @@ final class DiffusionRepositoryCreateController
 
     } else if ($this->isUsernamePasswordProtocol($proto)) {
       if ($credential) {
-        $password_type = PassphraseCredentialTypePassword::PROVIDES_TYPE;
+        $password_type = PassphrasePasswordCredentialType::PROVIDES_TYPE;
         if ($credential->getProvidesType() !== $password_type) {
         $c_credential->setError(pht('Invalid'));
         $page->addPageError(

src/applications/diffusion/data/DiffusionBrowseResultSet.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionBrowseResultSet {
+final class DiffusionBrowseResultSet extends Phobject {
 
   const REASON_IS_FILE              = 'is-file';
   const REASON_IS_DELETED           = 'is-deleted';

src/applications/diffusion/data/DiffusionFileContent.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionFileContent {
+final class DiffusionFileContent extends Phobject {
 
   private $corpus;
   private $blameDict;

src/applications/diffusion/data/DiffusionGitBranch.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionGitBranch {
+final class DiffusionGitBranch extends Phobject {
 
   const DEFAULT_GIT_REMOTE = 'origin';
 

src/applications/diffusion/data/DiffusionPathChange.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionPathChange {
+final class DiffusionPathChange extends Phobject {
 
   private $path;
   private $commitIdentifier;

src/applications/diffusion/data/DiffusionRepositoryPath.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionRepositoryPath {
+final class DiffusionRepositoryPath extends Phobject {
 
   private $fullPath;
   private $path;

src/applications/diffusion/data/DiffusionRepositoryTag.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionRepositoryTag {
+final class DiffusionRepositoryTag extends Phobject {
 
   private $author;
   private $epoch;

src/applications/diffusion/protocol/DiffusionMercurialWireProtocol.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionMercurialWireProtocol {
+final class DiffusionMercurialWireProtocol extends Phobject {
 
   public static function getCommandArgs($command) {
     // We need to enumerate all of the Mercurial wire commands because the

src/applications/diffusion/query/DiffusionCommitQuery.php

@@ -193,6 +193,7 @@ final class DiffusionCommitQuery
       if ($repo) {
         $commit->attachRepository($repo);
       } else {
+        $this->didRejectResult($commit);
         unset($commits[$key]);
         continue;
       }

src/applications/diffusion/query/DiffusionPathQuery.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionPathQuery {
+final class DiffusionPathQuery extends Phobject {
 
   private $pathIDs;
 

src/applications/diffusion/query/DiffusionRenameHistoryQuery.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionRenameHistoryQuery {
+final class DiffusionRenameHistoryQuery extends Phobject {
 
   private $oldCommit;
   private $wasCreated;

src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionPathChangeQuery {
+final class DiffusionPathChangeQuery extends Phobject {
 
   private $request;
   private $limit;

src/applications/diffusion/query/pathid/DiffusionPathIDQuery.php

@@ -3,7 +3,9 @@
 /**
  * @task pathutil Path Utilities
  */
-final class DiffusionPathIDQuery {
+final class DiffusionPathIDQuery extends Phobject {
+
+  private $paths = array();
 
   public function __construct(array $paths) {
     $this->paths = $paths;

src/applications/diffusion/request/DiffusionRequest.php

@@ -7,7 +7,7 @@
  * @task new Creating Requests
  * @task uri Managing Diffusion URIs
  */
-abstract class DiffusionRequest {
+abstract class DiffusionRequest extends Phobject {
 
   protected $callsign;
   protected $path;

src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php

@@ -4,7 +4,6 @@
  * This protocol has a good spec here:
  *
  *   http://svn.apache.org/repos/asf/subversion/trunk/subversion/libsvn_ra_svn/protocol
- *
  */
 final class DiffusionSubversionServeSSHWorkflow
   extends DiffusionSubversionSSHWorkflow {

src/applications/diffusion/symbol/DiffusionExternalSymbolQuery.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DiffusionExternalSymbolQuery {
+final class DiffusionExternalSymbolQuery extends Phobject {
   private $languages = array();
   private $types = array();
   private $names = array();

src/applications/diffusion/symbol/DiffusionExternalSymbolsSource.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class DiffusionExternalSymbolsSource {
+abstract class DiffusionExternalSymbolsSource extends Phobject {
 
   /**
    * @return list of PhabricatorRepositorySymbol

src/applications/diviner/atom/DivinerAtom.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DivinerAtom {
+final class DivinerAtom extends Phobject {
 
   const TYPE_ARTICLE   = 'article';
   const TYPE_CLASS     = 'class';