revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-11 15:21:03 +01:00
Code Issues Releases Wiki Activity

Stop "Mute Notifications" on Bulk Jobs from fataling

Browse source 
Summary:
See <https://discourse.phabricator-community.org/t/unhandled-exception-muting-completed-bulk-jobs/2449>. Bulk Jobs have an "edge" table but currently do not support edge transactions. Add support.

This stops "Mute Notifications" from fataling.

The action probably doesn't do what the reporting user expects (it stops edits to the job object from sending notifications; it does not stop the edits the job performs from sending notifications) but I think this change puts us in a better place no matter what, even if we eventually clarify or remove this behavior.

Test Plan: Clicked "Mute Notifications" on a bulk job, got an effect instead of a fatal.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20226
This commit is contained in:
epriestley 2019-02-28 09:44:20 -08:00
parent 27ea775fda
commit 54006f4817
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/infrastructure/daemon/workers/editor/PhabricatorWorkerBulkJobEditor.php
View file

@ -15,6 +15,7 @@ final class PhabricatorWorkerBulkJobEditor
$types = parent::getTransactionTypes(); $types = parent::getTransactionTypes();
$types[] = PhabricatorWorkerBulkJobTransaction::TYPE_STATUS; $types[] = PhabricatorWorkerBulkJobTransaction::TYPE_STATUS;
$types[] = PhabricatorTransactions::TYPE_EDGE;
return $types; return $types;
} }