From 5444e1c885c337ede0f1fb4ad1916ae0b49b1413 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Wed, 17 Apr 2024 13:12:24 +0200 Subject: [PATCH] Fix PHP 8.1 "strlen(null)" exception for "/bin/storage renamespace" without parameter Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. This patch also fixes two similar strlen() occurrences in the same source file. ``` ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php:62] ``` Test Plan: Run `../phorge/bin/storage renamespace`: Get no `strlen()` error anymore but only expected output `Usage Exception: Specify the dumpfile to read with "--input", or use "--live" to generate one automatically.` Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25592 --- .../PhabricatorStorageManagementRenamespaceWorkflow.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php index 0540bb3ebc..8a0c7817b7 100644 --- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php +++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementRenamespaceWorkflow.php @@ -59,7 +59,7 @@ final class PhabricatorStorageManagementRenamespaceWorkflow $input = $args->getArg('input'); $is_live = $args->getArg('live'); - if (!strlen($input) && !$is_live) { + if (!phutil_nonempty_string($input) && !$is_live) { throw new PhutilArgumentUsageException( pht( 'Specify the dumpfile to read with "--input", or use "--live" to '. @@ -67,7 +67,7 @@ final class PhabricatorStorageManagementRenamespaceWorkflow } $from = $args->getArg('from'); - if (!strlen($from)) { + if (!phutil_nonempty_string($from)) { throw new PhutilArgumentUsageException( pht( 'Specify namespace to rename from with %s.', @@ -75,7 +75,7 @@ final class PhabricatorStorageManagementRenamespaceWorkflow } $to = $args->getArg('to'); - if (!strlen($to)) { + if (!phutil_nonempty_string($to)) { throw new PhutilArgumentUsageException( pht( 'Specify namespace to rename to with %s.',