From 54b952df5d1483a61ceabaf44f92a35df4e0e983 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 14 Dec 2018 15:18:11 -0800 Subject: [PATCH] Fix weird gap/spacing on user "Manage" page Summary: I added this recently for debugging test notifications, but goofed up the markup, thought it was just some weird layout issue, and never got back to it. Test Plan: {F6063455} Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D19892 --- ...abricatorPeopleProfileManageController.php | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/applications/people/controller/PhabricatorPeopleProfileManageController.php b/src/applications/people/controller/PhabricatorPeopleProfileManageController.php index 55f9311ada..046726f39e 100644 --- a/src/applications/people/controller/PhabricatorPeopleProfileManageController.php +++ b/src/applications/people/controller/PhabricatorPeopleProfileManageController.php @@ -36,17 +36,18 @@ final class PhabricatorPeopleProfileManageController $crumbs->addTextCrumb(pht('Manage')); $crumbs->setBorder(true); + $timeline = $this->buildTransactionTimeline( + $user, + new PhabricatorPeopleTransactionQuery()); + $timeline->setShouldTerminate(true); + $manage = id(new PHUITwoColumnView()) ->setHeader($header) ->addClass('project-view-home') ->addClass('project-view-people-home') ->setCurtain($curtain) - ->addPropertySection(pht('Details'), $properties); - - $timeline = $this->buildTransactionTimeline( - $user, - new PhabricatorPeopleTransactionQuery()); - $timeline->setShouldTerminate(true); + ->addPropertySection(pht('Details'), $properties) + ->setMainColumn($timeline); return $this->newPage() ->setTitle( @@ -56,11 +57,7 @@ final class PhabricatorPeopleProfileManageController )) ->setNavigation($nav) ->setCrumbs($crumbs) - ->appendChild( - array( - $manage, - $timeline, - )); + ->appendChild($manage); } private function buildPropertyView(PhabricatorUser $user) {