revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 06:20:56 +01:00
Code Issues Releases Wiki Activity

Fix issue where new transaction comments can be spread across multiple transactions

Browse source 
Summary: Ref T2222. We need this `clone` when constructing the new multi-comments in Differential, or we get double-comments internally. This shows up as emails with double comment text.

Test Plan: Sent some "Accept + comment" emails, only one comment in the body.

Reviewers: chad, btrahan

Reviewed By: chad

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8206
This commit is contained in:
epriestley 2014-02-12 09:06:24 -08:00
parent db66cd830d
commit 54ce4a719e
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/differential/storage/DifferentialComment.php
View file

@ -21,6 +21,12 @@ final class DifferentialComment extends DifferentialDAO
private $arbitraryDiffForFacebook;
private $proxyComment;
public function __clone() {
if ($this->proxyComment) {
$this->proxyComment = clone $this->proxyComment;
}
}
public function getContent() {
return $this->getProxyComment()->getContent();
}