Define JavaScript functions before they are used

Summary: This should be a fairly minor change that silences a bunch of JSHint warnings.

Test Plan: `arc lint` showed less warnings.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11064

resources/celerity/map.php

@@ -9,7 +9,7 @@ return array(
   'names' => array(
     'core.pkg.css' => 'f588bfc3',
     'core.pkg.js' => '2d1f7db1',
-    'darkconsole.pkg.js' => 'ac37f0cd',
+    'darkconsole.pkg.js' => 'd326843f',
     'differential.pkg.css' => '8af45893',
     'differential.pkg.js' => '42c10e78',
     'diffusion.pkg.css' => '591664fa',
@@ -348,7 +348,7 @@ return array(
     'rsrc/js/application/conpherence/behavior-menu.js' => 'f0a41b9f',
     'rsrc/js/application/conpherence/behavior-pontificate.js' => '85ab3c8e',
     'rsrc/js/application/conpherence/behavior-widget-pane.js' => '40b1ff90',
-    'rsrc/js/application/countdown/timer.js' => '361e3ed3',
+    'rsrc/js/application/countdown/timer.js' => 'e4cc26b3',
     'rsrc/js/application/dashboard/behavior-dashboard-async-panel.js' => '469c0d9e',
     'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => '82439934',
     'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
@@ -381,7 +381,7 @@ return array(
     'rsrc/js/application/herald/HeraldRuleEditor.js' => '335fd41f',
     'rsrc/js/application/herald/PathTypeahead.js' => 'f7fc67ec',
     'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3',
-    'rsrc/js/application/maniphest/behavior-batch-editor.js' => 'f588412e',
+    'rsrc/js/application/maniphest/behavior-batch-editor.js' => 'f24f3253',
     'rsrc/js/application/maniphest/behavior-batch-selector.js' => '7b98d7c5',
     'rsrc/js/application/maniphest/behavior-line-chart.js' => '22e16ae7',
     'rsrc/js/application/maniphest/behavior-list-edit.js' => 'a9f88de2',
@@ -394,10 +394,10 @@ return array(
     'rsrc/js/application/passphrase/phame-credential-control.js' => '3d51a746',
     'rsrc/js/application/phame/phame-post-preview.js' => 'be807912',
     'rsrc/js/application/pholio/behavior-pholio-mock-edit.js' => '9c2623f4',
-    'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => '152178f0',
-    'rsrc/js/application/phortune/behavior-balanced-payment-form.js' => '3b3e1664',
-    'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => '1693a296',
-    'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'ab8d2723',
+    'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => '9b04250e',
+    'rsrc/js/application/phortune/behavior-balanced-payment-form.js' => 'b2c03e60',
+    'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => '3f5d6dbf',
+    'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'fc91ab6c',
     'rsrc/js/application/phortune/phortune-credit-card-form.js' => '2290aeef',
     'rsrc/js/application/policy/behavior-policy-control.js' => 'f3fef818',
     'rsrc/js/application/policy/behavior-policy-rule-editor.js' => 'fe9a552f',
@@ -447,7 +447,7 @@ return array(
     'rsrc/js/core/behavior-autofocus.js' => '7319e029',
     'rsrc/js/core/behavior-choose-control.js' => '6153c708',
     'rsrc/js/core/behavior-crop.js' => 'fa0f4fc2',
-    'rsrc/js/core/behavior-dark-console.js' => '357b6e9b',
+    'rsrc/js/core/behavior-dark-console.js' => 'caa97e33',
     'rsrc/js/core/behavior-device.js' => '03d6ed07',
     'rsrc/js/core/behavior-drag-and-drop-textarea.js' => '92eb531d',
     'rsrc/js/core/behavior-error-log.js' => '6882e80a',
@@ -545,15 +545,15 @@ return array(
     'javelin-behavior-aphront-more' => 'a80d0378',
     'javelin-behavior-audio-source' => '59b251eb',
     'javelin-behavior-audit-preview' => 'd835b03a',
-    'javelin-behavior-balanced-payment-form' => '3b3e1664',
+    'javelin-behavior-balanced-payment-form' => 'b2c03e60',
     'javelin-behavior-boards-dropdown' => '0ec56e1d',
     'javelin-behavior-choose-control' => '6153c708',
     'javelin-behavior-config-reorder-fields' => '14a827de',
     'javelin-behavior-conpherence-menu' => 'f0a41b9f',
     'javelin-behavior-conpherence-pontificate' => '85ab3c8e',
     'javelin-behavior-conpherence-widget-pane' => '40b1ff90',
-    'javelin-behavior-countdown-timer' => '361e3ed3',
-    'javelin-behavior-dark-console' => '357b6e9b',
+    'javelin-behavior-countdown-timer' => 'e4cc26b3',
+    'javelin-behavior-dark-console' => 'caa97e33',
     'javelin-behavior-dashboard-async-panel' => '469c0d9e',
     'javelin-behavior-dashboard-move-panels' => '82439934',
     'javelin-behavior-dashboard-query-panel-select' => '453c5375',
@@ -589,7 +589,7 @@ return array(
     'javelin-behavior-lightbox-attachments' => 'f8ba29d7',
     'javelin-behavior-line-chart' => '22e16ae7',
     'javelin-behavior-load-blame' => '42126667',
-    'javelin-behavior-maniphest-batch-editor' => 'f588412e',
+    'javelin-behavior-maniphest-batch-editor' => 'f24f3253',
     'javelin-behavior-maniphest-batch-selector' => '7b98d7c5',
     'javelin-behavior-maniphest-list-editor' => 'a9f88de2',
     'javelin-behavior-maniphest-subpriority-editor' => '84845b5b',
@@ -623,7 +623,7 @@ return array(
     'javelin-behavior-phabricator-watch-anchor' => '06e05112',
     'javelin-behavior-phame-post-preview' => 'be807912',
     'javelin-behavior-pholio-mock-edit' => '9c2623f4',
-    'javelin-behavior-pholio-mock-view' => '152178f0',
+    'javelin-behavior-pholio-mock-view' => '9b04250e',
     'javelin-behavior-phui-object-box-tabs' => '2bfa2836',
     'javelin-behavior-phui-timeline-dropdown-menu' => '4d94d9c3',
     'javelin-behavior-policy-control' => 'f3fef818',
@@ -642,8 +642,8 @@ return array(
     'javelin-behavior-search-reorder-queries' => 'e9581f08',
     'javelin-behavior-select-on-click' => '4e3e79a6',
     'javelin-behavior-slowvote-embed' => 'd6f54db0',
-    'javelin-behavior-stripe-payment-form' => '1693a296',
-    'javelin-behavior-test-payment-form' => 'ab8d2723',
+    'javelin-behavior-stripe-payment-form' => '3f5d6dbf',
+    'javelin-behavior-test-payment-form' => 'fc91ab6c',
     'javelin-behavior-toggle-class' => 'e566f52c',
     'javelin-behavior-view-placeholder' => '2fa810fc',
     'javelin-behavior-workflow' => '0a3f3021',
@@ -857,6 +857,20 @@ return array(
       'javelin-workflow',
       'phabricator-draggable-list',
     ),
+    '7319e029' => array(
+      'javelin-behavior',
+      'javelin-dom',
+    ),
+    '97258e55' => array(
+      'javelin-install',
+      'javelin-stratcom',
+      'javelin-util',
+      'javelin-behavior',
+      'javelin-json',
+      'javelin-dom',
+      'javelin-resource',
+      'javelin-routable',
+    ),
     '06e05112' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -935,25 +949,6 @@ return array(
       'javelin-request',
       'javelin-util',
     ),
-    '152178f0' => array(
-      'javelin-behavior',
-      'javelin-util',
-      'javelin-stratcom',
-      'javelin-dom',
-      'javelin-vector',
-      'javelin-magical-init',
-      'javelin-request',
-      'javelin-history',
-      'javelin-workflow',
-      'javelin-mask',
-      'javelin-behavior-device',
-      'phabricator-keyboard-shortcut',
-    ),
-    '1693a296' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'phortune-credit-card-form',
-    ),
     '1ae869f2' => array(
       'javelin-install',
       'javelin-util',
@@ -1028,18 +1023,6 @@ return array(
       'javelin-json',
       'phabricator-prefab',
     ),
-    '357b6e9b' => array(
-      'javelin-behavior',
-      'javelin-stratcom',
-      'javelin-util',
-      'javelin-dom',
-      'javelin-request',
-      'phabricator-keyboard-shortcut',
-    ),
-    '361e3ed3' => array(
-      'javelin-behavior',
-      'javelin-dom',
-    ),
     '3ab51e2c' => array(
       'javelin-behavior',
       'javelin-behavior-device',
@@ -1048,11 +1031,6 @@ return array(
       'javelin-dom',
       'javelin-magical-init',
     ),
-    '3b3e1664' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'phortune-credit-card-form',
-    ),
     '3d51a746' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1067,6 +1045,11 @@ return array(
       'javelin-stratcom',
       'phabricator-tooltip',
     ),
+    '3f5d6dbf' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'phortune-credit-card-form',
+    ),
     '40a6a403' => array(
       'javelin-install',
       'javelin-dom',
@@ -1279,10 +1262,6 @@ return array(
       'javelin-stratcom',
       'phabricator-prefab',
     ),
-    '7319e029' => array(
-      'javelin-behavior',
-      'javelin-dom',
-    ),
     '76b9fc3e' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1425,21 +1404,25 @@ return array(
       'javelin-workflow',
       'javelin-util',
     ),
-    '97258e55' => array(
-      'javelin-install',
-      'javelin-stratcom',
-      'javelin-util',
-      'javelin-behavior',
-      'javelin-json',
-      'javelin-dom',
-      'javelin-resource',
-      'javelin-routable',
-    ),
     '988040b4' => array(
       'javelin-install',
       'javelin-dom',
       'javelin-reactor-dom',
     ),
+    '9b04250e' => array(
+      'javelin-behavior',
+      'javelin-util',
+      'javelin-stratcom',
+      'javelin-dom',
+      'javelin-vector',
+      'javelin-magical-init',
+      'javelin-request',
+      'javelin-history',
+      'javelin-workflow',
+      'javelin-mask',
+      'javelin-behavior-device',
+      'phabricator-keyboard-shortcut',
+    ),
     '9c2623f4' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1536,11 +1519,6 @@ return array(
       'javelin-util',
       'phabricator-keyboard-shortcut',
     ),
-    'ab8d2723' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'phortune-credit-card-form',
-    ),
     'ad7a69ca' => array(
       'javelin-install',
       'javelin-util',
@@ -1559,6 +1537,11 @@ return array(
       'javelin-uri',
       'javelin-request',
     ),
+    'b2c03e60' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'phortune-credit-card-form',
+    ),
     'b3a4b884' => array(
       'javelin-behavior',
       'phabricator-prefab',
@@ -1671,6 +1654,14 @@ return array(
       'javelin-stratcom',
       'phabricator-phtize',
     ),
+    'caa97e33' => array(
+      'javelin-behavior',
+      'javelin-stratcom',
+      'javelin-util',
+      'javelin-dom',
+      'javelin-request',
+      'phabricator-keyboard-shortcut',
+    ),
     'cc1bd0b0' => array(
       'javelin-install',
       'javelin-event',
@@ -1782,6 +1773,10 @@ return array(
       'javelin-dom',
       'javelin-uri',
     ),
+    'e4cc26b3' => array(
+      'javelin-behavior',
+      'javelin-dom',
+    ),
     'e566f52c' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1836,6 +1831,14 @@ return array(
       'javelin-request',
       'javelin-workflow',
     ),
+    'f24f3253' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-util',
+      'phabricator-prefab',
+      'multirow-row-manager',
+      'javelin-json',
+    ),
     'f36e01af' => array(
       'javelin-behavior',
       'javelin-behavior-device',
@@ -1852,14 +1855,6 @@ return array(
       'phuix-action-view',
       'javelin-workflow',
     ),
-    'f588412e' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-util',
-      'phabricator-prefab',
-      'multirow-row-manager',
-      'javelin-json',
-    ),
     'f6555212' => array(
       'javelin-install',
       'javelin-reactornode',
@@ -1923,6 +1918,11 @@ return array(
       'javelin-vector',
       'javelin-magical-init',
     ),
+    'fc91ab6c' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'phortune-credit-card-form',
+    ),
     'fcba4ecc' => array(
       'javelin-install',
       'javelin-util',

webroot/rsrc/js/application/countdown/timer.js

@@ -5,15 +5,12 @@
  */
 
 JX.behavior('countdown-timer', function(config) {
-
   try {
     var container = JX.$(config.container);
   } catch (ignored) {
     return;
   }
 
-  calculateTimeLeft();
-
   function setComponent(which, content) {
     var component = JX.DOM.find(container, '*', 'phabricator-timer-' + which);
     JX.DOM.setContent(component, content);
@@ -54,4 +51,5 @@ JX.behavior('countdown-timer', function(config) {
     setComponent('seconds', [seconds, JX.$N('small', {}, ['.', partial])]);
   }
 
+  calculateTimeLeft();
 });

webroot/rsrc/js/application/maniphest/behavior-batch-editor.js

@@ -9,16 +9,12 @@
  */
 
 JX.behavior('maniphest-batch-editor', function(config) {
-
   var root = JX.$(config.root);
   var editor_table = JX.DOM.find(root, 'table', 'maniphest-batch-actions');
   var manager = new JX.MultirowRowManager(editor_table);
   var action_rows = [];
 
-  addRow({});
-
   function renderRow() {
-
     var action_select = JX.Prefab.renderSelect(
       {
         'add_project': 'Add Projects',
@@ -119,6 +115,8 @@ JX.behavior('maniphest-batch-editor', function(config) {
     input.value = JX.JSON.stringify(actions);
   }
 
+  addRow({});
+
   JX.DOM.listen(
     root,
     'click',

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

@@ -700,9 +700,6 @@ JX.behavior('pholio-mock-view', function(config) {
     e.kill();
   });
 
-  JX.Stratcom.listen('click', 'pholio-device-lightbox', lightbox_detach);
-  JX.Stratcom.listen('resize', null, lightbox_resize);
-
   function lightbox_attach() {
     JX.DOM.alterClass(document.body, 'lightbox-attached', true);
     JX.Mask.show('jx-dark-mask');
@@ -746,6 +743,9 @@ JX.behavior('pholio-mock-view', function(config) {
     return el;
   }
 
+  JX.Stratcom.listen('click', 'pholio-device-lightbox', lightbox_detach);
+  JX.Stratcom.listen('resize', null, lightbox_resize);
+
 
 /* -(  Preload  )------------------------------------------------------------ */
 

webroot/rsrc/js/application/phortune/behavior-balanced-payment-form.js

@@ -8,8 +8,6 @@
 JX.behavior('balanced-payment-form', function(config) {
   balanced.init(config.balancedMarketplaceURI);
 
-  var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
-
   function onsubmit(card_data) {
     var errors = [];
 
@@ -54,4 +52,6 @@ JX.behavior('balanced-payment-form', function(config) {
 
     ccform.submitForm(errors, {balancedMarketplaceURI: token});
   }
+
+  var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
 });

webroot/rsrc/js/application/phortune/behavior-stripe-payment-form.js

@@ -8,8 +8,6 @@
 JX.behavior('stripe-payment-form', function(config) {
   Stripe.setPublishableKey(config.stripePublishableKey);
 
-  var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
-
   function onsubmit(card_data) {
     var errors = [];
 
@@ -54,4 +52,5 @@ JX.behavior('stripe-payment-form', function(config) {
     ccform.submitForm(errors, {stripeCardToken: token});
   }
 
+  var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
 });

webroot/rsrc/js/application/phortune/behavior-test-payment-form.js

@@ -6,8 +6,6 @@
  */
 
 JX.behavior('test-payment-form', function(config) {
-  var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
-
   function onsubmit() {
     onresponse();
   }
@@ -16,4 +14,5 @@ JX.behavior('test-payment-form', function(config) {
     ccform.submitForm([], {test: true});
   }
 
+  var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
 });

webroot/rsrc/js/core/behavior-dark-console.js

@@ -17,8 +17,6 @@ JX.behavior('dark-console', function(config, statics) {
     config.color = root.getAttribute('data-console-color');
   }
 
-  add_request(config);
-
   // Do first-time setup.
   function setup_console() {
     statics.root = JX.$('darkconsole');
@@ -248,4 +246,5 @@ JX.behavior('dark-console', function(config, statics) {
       .register();
   }
 
+  add_request(config);
 });