revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-04 10:58:25 +01:00
Code Issues Releases Wiki Activity

Simplify some transaction translations

Browse source 
Summary: Ref T8700, I don't believe we need to be specific here about the object, since it displays on the object.

Test Plan: Change policy a few times on a task, see new translation

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T8700

Differential Revision: https://secure.phabricator.com/D13913
This commit is contained in:
Chad Little 2015-08-16 17:47:58 -07:00
parent 36a50ccbae
commit 5590642a1d
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
View file

@ -642,23 +642,20 @@ abstract class PhabricatorApplicationTransaction
$this->renderHandleLink($author_phid)); $this->renderHandleLink($author_phid));
case PhabricatorTransactions::TYPE_VIEW_POLICY: case PhabricatorTransactions::TYPE_VIEW_POLICY:
return pht( return pht(
'%s changed the visibility of this %s from "%s" to "%s".', '%s changed the visibility from "%s" to "%s".',
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
$this->getApplicationObjectTypeName(),
$this->renderPolicyName($old, 'old'), $this->renderPolicyName($old, 'old'),
$this->renderPolicyName($new, 'new')); $this->renderPolicyName($new, 'new'));
case PhabricatorTransactions::TYPE_EDIT_POLICY: case PhabricatorTransactions::TYPE_EDIT_POLICY:
return pht( return pht(
'%s changed the edit policy of this %s from "%s" to "%s".', '%s changed the edit policy from "%s" to "%s".',
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
$this->getApplicationObjectTypeName(),
$this->renderPolicyName($old, 'old'), $this->renderPolicyName($old, 'old'),
$this->renderPolicyName($new, 'new')); $this->renderPolicyName($new, 'new'));
case PhabricatorTransactions::TYPE_JOIN_POLICY: case PhabricatorTransactions::TYPE_JOIN_POLICY:
return pht( return pht(
'%s changed the join policy of this %s from "%s" to "%s".', '%s changed the join policy from "%s" to "%s".',
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
$this->getApplicationObjectTypeName(),
$this->renderPolicyName($old, 'old'), $this->renderPolicyName($old, 'old'),
$this->renderPolicyName($new, 'new')); $this->renderPolicyName($new, 'new'));
case PhabricatorTransactions::TYPE_SPACE: case PhabricatorTransactions::TYPE_SPACE: