revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Add tipDirection to PHUIBadgeMiniView

Browse source 
Summary: Makes PHUIBadgeMiniView a little easier to dictate layout. Apply in Timeline.

Test Plan: Tested supercalifragilisticexpialidocious as a badge, saw it align properly.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13729
This commit is contained in:
Chad Little 2015-07-27 07:51:53 -07:00
parent bccdbacf44
commit 559bcc42c2
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/view/phui/PHUIBadgeMiniView.php
View file

@ -6,6 +6,7 @@ final class PHUIBadgeMiniView extends AphrontTagView {
private $icon; private $icon;
private $quality; private $quality;
private $header; private $header;
private $tipDirection;
public function setIcon($icon) { public function setIcon($icon) {
$this->icon = $icon; $this->icon = $icon;
@ -27,6 +28,11 @@ final class PHUIBadgeMiniView extends AphrontTagView {
return $this; return $this;
} }
public function setTipDirection($direction) {
$this->tipDirection = $direction;
return $this;
}
protected function getTagName() { protected function getTagName() {
if ($this->href) { if ($this->href) {
return 'a'; return 'a';
@ -51,6 +57,8 @@ final class PHUIBadgeMiniView extends AphrontTagView {
'href' => $this->href, 'href' => $this->href,
'meta' => array( 'meta' => array(
'tip' => $this->header, 'tip' => $this->header,
'align' => $this->tipDirection,
'size' => 300,
), ),
); );
} }

1
src/view/phui/PHUITimelineView.php
View file

@ -255,6 +255,7 @@ final class PHUITimelineView extends AphrontView {
->setIcon($badge->getIcon()) ->setIcon($badge->getIcon())
->setQuality($badge->getQuality()) ->setQuality($badge->getQuality())
->setHeader($badge->getName()) ->setHeader($badge->getName())
->setTipDirection('E')
->setHref('/badges/view/'.$badge->getID()); ->setHref('/badges/view/'.$badge->getID());
$event->addBadge($badge_view); $event->addBadge($badge_view);