mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-29 10:12:41 +01:00
Fix a bad method call signature throwing exceptions in newer Node
Summary: Ref T13222. See PHI996. Ref T10743. For context, perhaps see T12171. Node changed some signatures, behaviors, and error handling here in recent versions. As far as I can tell: - The `script.runInNewContext(...)` method has never taken a `path` parameter, and passing the path has always been wrong. - The `script.runInNewContext(...)` method started taking an `[options]` parameter at some point, and validating it, so the bad `path` parameter now throws. - `vm.createScript(...)` is "soft deprecated" but basically fine, and keeping it looks more compatible. This seems like the smallest and most compatible correct change. Test Plan: Under Node 10, started Aphlict. Before: fatal error on bad `options` parameter to `runInNewContext()` (expected dictionary). After: notification server starts. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13222, T10743 Differential Revision: https://secure.phabricator.com/D19860
This commit is contained in:
parent
508df60a62
commit
55a1ef339f
2 changed files with 2 additions and 2 deletions
|
@ -214,7 +214,7 @@ return array(
|
||||||
'rsrc/externals/javelin/core/__tests__/stratcom.js' => '88bf7313',
|
'rsrc/externals/javelin/core/__tests__/stratcom.js' => '88bf7313',
|
||||||
'rsrc/externals/javelin/core/__tests__/util.js' => 'e251703d',
|
'rsrc/externals/javelin/core/__tests__/util.js' => 'e251703d',
|
||||||
'rsrc/externals/javelin/core/init.js' => '8d83d2a1',
|
'rsrc/externals/javelin/core/init.js' => '8d83d2a1',
|
||||||
'rsrc/externals/javelin/core/init_node.js' => 'c234aded',
|
'rsrc/externals/javelin/core/init_node.js' => 'f7732951',
|
||||||
'rsrc/externals/javelin/core/install.js' => '05270951',
|
'rsrc/externals/javelin/core/install.js' => '05270951',
|
||||||
'rsrc/externals/javelin/core/util.js' => '93cc50d6',
|
'rsrc/externals/javelin/core/util.js' => '93cc50d6',
|
||||||
'rsrc/externals/javelin/docs/Base.js' => '74676256',
|
'rsrc/externals/javelin/docs/Base.js' => '74676256',
|
||||||
|
|
|
@ -49,7 +49,7 @@ JX.require = function(thing) {
|
||||||
}
|
}
|
||||||
|
|
||||||
vm.createScript(content, path)
|
vm.createScript(content, path)
|
||||||
.runInNewContext(sandbox, path);
|
.runInNewContext(sandbox);
|
||||||
};
|
};
|
||||||
|
|
||||||
exports.JX = JX;
|
exports.JX = JX;
|
||||||
|
|
Loading…
Reference in a new issue