From 55c3c6cb1241b1676b032666f177f056e610eab0 Mon Sep 17 00:00:00 2001
From: Edward Speyer <edward@fb.com>
Date: Tue, 7 May 2013 11:13:22 +0100
Subject: [PATCH] Some ReleephRequests don't have diffs

Summary: Not every commit requested in Releeph has to have come from a Differential revision.  If you have a Releeph request for a commit without a Differential revision, you currently get this lovely error in the logs: {P824}.  This diff silences the howling.

Test Plan: Load a Releeph branch page; observe log silence.

Reviewers: wez, epriestley

Reviewed By: epriestley

CC: epriestley, aran, SEJeff, Korvin

Differential Revision: https://secure.phabricator.com/D5823
---
 src/applications/releeph/storage/ReleephRequest.php | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/applications/releeph/storage/ReleephRequest.php b/src/applications/releeph/storage/ReleephRequest.php
index ce01ead6d8..30cb80c487 100644
--- a/src/applications/releeph/storage/ReleephRequest.php
+++ b/src/applications/releeph/storage/ReleephRequest.php
@@ -274,6 +274,10 @@ final class ReleephRequest extends ReleephDAO {
   }
 
   public function loadDifferentialRevision() {
+    $diff_phid = $this->loadRequestCommitDiffPHID();
+    if (!$diff_phid) {
+      return null;
+    }
     return $this->loadOneRelative(
         new DifferentialRevision(),
         'phid',