Provide more buildXClause() and buildXClauseParts() on PolicyAwareQuery

Summary:
Ref T4100. Ref T5595. These functions are trivial for now, but move us toward being able to define more default query behavior by default.

Future changes will give these methods meaningful, nontrivial behaviors.

Test Plan: `arc unit --everything`

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5595, T4100

Differential Revision: https://secure.phabricator.com/D12454

src/applications/almanac/query/AlmanacServiceQuery.php

@@ -75,7 +75,7 @@ final class AlmanacServiceQuery
     return $table->loadAllFromArray($data);
   }
 
-  protected function buildJoinClause($conn_r) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn_r) {
     $joins = array();
 
     if ($this->devicePHIDs !== null) {

src/applications/conpherence/query/ConpherenceThreadQuery.php

@@ -129,7 +129,7 @@ final class ConpherenceThreadQuery
     }
   }
 
-  private function buildJoinClause($conn_r) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn_r) {
     $joins = array();
 
     if ($this->participantPHIDs !== null) {

src/applications/diffusion/query/DiffusionCommitQuery.php

@@ -511,7 +511,7 @@ final class DiffusionCommitQuery
     }
   }
 
-  private function buildJoinClause($conn_r) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn_r) {
     $joins = array();
     $audit_request = new PhabricatorRepositoryAuditRequest();
 

src/applications/feed/query/PhabricatorFeedQuery.php

@@ -37,7 +37,7 @@ final class PhabricatorFeedQuery
     return PhabricatorFeedStory::loadAllFromRows($data, $this->getViewer());
   }
 
-  private function buildJoinClause(AphrontDatabaseConnection $conn_r) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn_r) {
     // NOTE: We perform this join unconditionally (even if we have no filter
     // PHIDs) to omit rows which have no story references. These story data
     // rows are notifications or realtime alerts.

src/applications/files/query/PhabricatorFileQuery.php

@@ -215,7 +215,7 @@ final class PhabricatorFileQuery
     return $files;
   }
 
-  private function buildJoinClause(AphrontDatabaseConnection $conn_r) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn_r) {
     $joins = array();
 
     if ($this->transforms) {

src/applications/legalpad/query/LegalpadDocumentQuery.php

@@ -134,7 +134,7 @@ final class LegalpadDocumentQuery
     return $documents;
   }
 
-  private function buildJoinClause($conn_r) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn_r) {
     $joins = array();
 
     if ($this->contributorPHIDs !== null) {

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

@@ -35,7 +35,7 @@ final class PhabricatorOwnersPackageQuery
     return $table->loadAllFromArray($data);
   }
 
-  private function buildJoinClause(AphrontDatabaseConnection $conn_r) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn_r) {
     $joins = array();
 
     if ($this->ownerPHIDs) {

src/applications/phortune/query/PhortuneAccountQuery.php

@@ -102,7 +102,7 @@ final class PhortuneAccountQuery
     return $this->formatWhereClause($where);
   }
 
-  private function buildJoinClause(AphrontDatabaseConnection $conn) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn) {
     $joins = array();
 
     if ($this->memberPHIDs) {

src/applications/phortune/query/PhortuneMerchantQuery.php

@@ -82,7 +82,7 @@ final class PhortuneMerchantQuery
     return $this->formatWhereClause($where);
   }
 
-  private function buildJoinClause(AphrontDatabaseConnection $conn) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn) {
     $joins = array();
 
     if ($this->memberPHIDs !== null) {

src/applications/phriction/query/PhrictionDocumentQuery.php

@@ -190,7 +190,7 @@ final class PhrictionDocumentQuery
     return $documents;
   }
 
-  private function buildJoinClause(AphrontDatabaseConnection $conn) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn) {
     $join = '';
 
     if ($this->getOrderVector()->containsKey('updated')) {

src/applications/project/query/PhabricatorProjectQuery.php

@@ -336,7 +336,7 @@ final class PhabricatorProjectQuery
     }
   }
 
-  private function buildJoinClause($conn_r) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn_r) {
     $joins = array();
 
     if (!$this->needMembers !== null) {

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

@@ -145,7 +145,7 @@ final class PhabricatorWorkerTriggerQuery
     return $triggers;
   }
 
-  private function buildJoinClause(AphrontDatabaseConnection $conn_r) {
+  protected function buildJoinClause(AphrontDatabaseConnection $conn_r) {
     $joins = array();
 
     if (($this->nextEpochMin !== null) ||

src/infrastructure/query/PhabricatorQuery.php

@@ -1,17 +1,122 @@
 <?php
 
+/**
+ * @task format Formatting Query Clauses
+ */
 abstract class PhabricatorQuery {
 
+
   abstract public function execute();
 
-  final protected function formatWhereClause(array $parts) {
-    $parts = array_filter($parts);
 
+/* -(  Formatting Query Clauses  )------------------------------------------- */
+
+
+  /**
+   * @task format
+   */
+  protected function formatWhereClause(array $parts) {
+    $parts = $this->flattenSubclause($parts);
     if (!$parts) {
       return '';
     }
 
-    return 'WHERE ('.implode(') AND (', $parts).')';
+    return 'WHERE '.$this->formatWhereSubclause($parts);
+  }
+
+
+  /**
+   * @task format
+   */
+  protected function formatWhereSubclause(array $parts) {
+    $parts = $this->flattenSubclause($parts);
+    if (!$parts) {
+      return null;
+    }
+
+    return '('.implode(') AND (', $parts).')';
+  }
+
+
+  /**
+   * @task format
+   */
+  protected function formatSelectClause(array $parts) {
+    $parts = $this->flattenSubclause($parts);
+    if (!$parts) {
+      throw new Exception(pht('Can not build empty select clause!'));
+    }
+
+    return 'SELECT '.$this->formatSelectSubclause($parts);
+  }
+
+
+  /**
+   * @task format
+   */
+  protected function formatSelectSubclause(array $parts) {
+    $parts = $this->flattenSubclause($parts);
+    if (!$parts) {
+      return null;
+    }
+    return implode(', ', $parts);
+  }
+
+
+  /**
+   * @task format
+   */
+  protected function formatJoinClause(array $parts) {
+    $parts = $this->flattenSubclause($parts);
+    if (!$parts) {
+      return '';
+    }
+
+    return implode(' ', $parts);
+  }
+
+
+  /**
+   * @task format
+   */
+  protected function formatHavingClause(array $parts) {
+    $parts = $this->flattenSubclause($parts);
+    if (!$parts) {
+      return '';
+    }
+
+    return 'HAVING '.$this->formatHavingSubclause($parts);
+  }
+
+
+  /**
+   * @task format
+   */
+  protected function formatHavingSubclause(array $parts) {
+    $parts = $this->flattenSubclause($parts);
+    if (!$parts) {
+      return null;
+    }
+
+    return '('.implode(') AND (', $parts).')';
+  }
+
+
+  /**
+   * @task format
+   */
+  private function flattenSubclause(array $parts) {
+    $result = array();
+    foreach ($parts as $part) {
+      if (is_array($part)) {
+        foreach ($this->flattenSubclause($part) as $subpart) {
+          $result[] = $subpart;
+        }
+      } else if (strlen($part)) {
+        $result[] = $part;
+      }
+    }
+    return $result;
   }
 
 }

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

@@ -180,11 +180,84 @@ abstract class PhabricatorCursorPagedPolicyAwareQuery
 /* -(  Building Query Clauses  )--------------------------------------------- */
 
 
+  /**
+   * @task clauses
+   */
+  protected function buildSelectClause(AphrontDatabaseConnection $conn) {
+    $parts = $this->buildSelectClauseParts($conn);
+    return $this->formatSelectClause($parts);
+  }
+
+
+  /**
+   * @task clauses
+   */
+  protected function buildSelectClauseParts(AphrontDatabaseConnection $conn) {
+    $select = array();
+
+    $alias = $this->getPrimaryTableAlias();
+    if ($alias) {
+      $select[] = qsprintf($conn, '%T.*', $alias);
+    } else {
+      $select[] = '*';
+    }
+
+    return $select;
+  }
+
+
+  /**
+   * @task clauses
+   */
+  protected function buildJoinClause(AphrontDatabaseConnection $conn) {
+    $joins = $this->buildJoinClauseParts($conn);
+    return $this->formatJoinClause($joins);
+  }
+
+
+  /**
+   * @task clauses
+   */
+  protected function buildJoinClauseParts(AphrontDatabaseConnection $conn) {
+    $joins = array();
+    return $joins;
+  }
+
+
   /**
    * @task clauses
    */
   protected function buildWhereClause(AphrontDatabaseConnection $conn) {
-    throw new PhutilMethodNotImplementedException();
+    $where = $this->buildWhereClauseParts($conn);
+    return $this->formatWhereClause($where);
+  }
+
+
+  /**
+   * @task clauses
+   */
+  protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
+    $where = array();
+    $where[] = $this->buildPagingClause($conn);
+    return $where;
+  }
+
+
+  /**
+   * @task clauses
+   */
+  protected function buildHavingClause(AphrontDatabaseConnection $conn) {
+    $having = $this->buildHavingClauseParts($conn);
+    return $this->formatHavingClause($having);
+  }
+
+
+  /**
+   * @task clauses
+   */
+  protected function buildHavingClauseParts(AphrontDatabaseConnection $conn) {
+    $having = array();
+    return $having;
   }