1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00

Add specialcase area to remarkup when on a dark background.

Summary: Remarkup dark wrapper for Pholio/Remarkup, reusable

Test Plan: Tested a blockquote, list, and code segment

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2640

Differential Revision: https://secure.phabricator.com/D5196
This commit is contained in:
Chad Little 2013-03-03 13:10:59 -08:00
parent 3f1a78450c
commit 561698df60
3 changed files with 49 additions and 41 deletions

View file

@ -2924,7 +2924,7 @@ celerity_register_resource_map(array(
), ),
'phabricator-property-list-view-css' => 'phabricator-property-list-view-css' =>
array( array(
'uri' => '/res/a04cc81d/rsrc/css/layout/phabricator-property-list-view.css', 'uri' => '/res/fd680994/rsrc/css/layout/phabricator-property-list-view.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -2933,7 +2933,7 @@ celerity_register_resource_map(array(
), ),
'phabricator-remarkup-css' => 'phabricator-remarkup-css' =>
array( array(
'uri' => '/res/f444d7c9/rsrc/css/core/remarkup.css', 'uri' => '/res/3487373e/rsrc/css/core/remarkup.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -3435,7 +3435,7 @@ celerity_register_resource_map(array(
), array( ), array(
'packages' => 'packages' =>
array( array(
'9094ccaa' => 'f63b5397' =>
array( array(
'name' => 'core.pkg.css', 'name' => 'core.pkg.css',
'symbols' => 'symbols' =>
@ -3478,7 +3478,7 @@ celerity_register_resource_map(array(
35 => 'phabricator-object-item-list-view-css', 35 => 'phabricator-object-item-list-view-css',
36 => 'global-drag-and-drop-css', 36 => 'global-drag-and-drop-css',
), ),
'uri' => '/res/pkg/9094ccaa/core.pkg.css', 'uri' => '/res/pkg/f63b5397/core.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'd29c1557' => 'd29c1557' =>
@ -3666,17 +3666,17 @@ celerity_register_resource_map(array(
'reverse' => 'reverse' =>
array( array(
'aphront-attached-file-view-css' => 'e30a3fa8', 'aphront-attached-file-view-css' => 'e30a3fa8',
'aphront-crumbs-view-css' => '9094ccaa', 'aphront-crumbs-view-css' => 'f63b5397',
'aphront-dialog-view-css' => '9094ccaa', 'aphront-dialog-view-css' => 'f63b5397',
'aphront-error-view-css' => '9094ccaa', 'aphront-error-view-css' => 'f63b5397',
'aphront-form-view-css' => '9094ccaa', 'aphront-form-view-css' => 'f63b5397',
'aphront-list-filter-view-css' => '9094ccaa', 'aphront-list-filter-view-css' => 'f63b5397',
'aphront-pager-view-css' => '9094ccaa', 'aphront-pager-view-css' => 'f63b5397',
'aphront-panel-view-css' => '9094ccaa', 'aphront-panel-view-css' => 'f63b5397',
'aphront-table-view-css' => '9094ccaa', 'aphront-table-view-css' => 'f63b5397',
'aphront-tokenizer-control-css' => '9094ccaa', 'aphront-tokenizer-control-css' => 'f63b5397',
'aphront-tooltip-css' => '9094ccaa', 'aphront-tooltip-css' => 'f63b5397',
'aphront-typeahead-control-css' => '9094ccaa', 'aphront-typeahead-control-css' => 'f63b5397',
'differential-changeset-view-css' => '8aaacd1b', 'differential-changeset-view-css' => '8aaacd1b',
'differential-core-view-css' => '8aaacd1b', 'differential-core-view-css' => '8aaacd1b',
'differential-inline-comment-editor' => 'd2447f72', 'differential-inline-comment-editor' => 'd2447f72',
@ -3690,7 +3690,7 @@ celerity_register_resource_map(array(
'differential-table-of-contents-css' => '8aaacd1b', 'differential-table-of-contents-css' => '8aaacd1b',
'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88',
'global-drag-and-drop-css' => '9094ccaa', 'global-drag-and-drop-css' => 'f63b5397',
'inline-comment-summary-css' => '8aaacd1b', 'inline-comment-summary-css' => '8aaacd1b',
'javelin-aphlict' => 'd29c1557', 'javelin-aphlict' => 'd29c1557',
'javelin-behavior' => 'cd1d650a', 'javelin-behavior' => 'cd1d650a',
@ -3759,48 +3759,48 @@ celerity_register_resource_map(array(
'javelin-util' => 'cd1d650a', 'javelin-util' => 'cd1d650a',
'javelin-vector' => 'cd1d650a', 'javelin-vector' => 'cd1d650a',
'javelin-workflow' => 'cd1d650a', 'javelin-workflow' => 'cd1d650a',
'lightbox-attachment-css' => '9094ccaa', 'lightbox-attachment-css' => 'f63b5397',
'maniphest-task-summary-css' => 'e30a3fa8', 'maniphest-task-summary-css' => 'e30a3fa8',
'maniphest-transaction-detail-css' => 'e30a3fa8', 'maniphest-transaction-detail-css' => 'e30a3fa8',
'phabricator-busy' => 'd29c1557', 'phabricator-busy' => 'd29c1557',
'phabricator-content-source-view-css' => '8aaacd1b', 'phabricator-content-source-view-css' => '8aaacd1b',
'phabricator-core-buttons-css' => '9094ccaa', 'phabricator-core-buttons-css' => 'f63b5397',
'phabricator-core-css' => '9094ccaa', 'phabricator-core-css' => 'f63b5397',
'phabricator-crumbs-view-css' => '9094ccaa', 'phabricator-crumbs-view-css' => 'f63b5397',
'phabricator-directory-css' => '9094ccaa', 'phabricator-directory-css' => 'f63b5397',
'phabricator-drag-and-drop-file-upload' => 'd2447f72', 'phabricator-drag-and-drop-file-upload' => 'd2447f72',
'phabricator-dropdown-menu' => 'd29c1557', 'phabricator-dropdown-menu' => 'd29c1557',
'phabricator-file-upload' => 'd29c1557', 'phabricator-file-upload' => 'd29c1557',
'phabricator-filetree-view-css' => '9094ccaa', 'phabricator-filetree-view-css' => 'f63b5397',
'phabricator-flag-css' => '9094ccaa', 'phabricator-flag-css' => 'f63b5397',
'phabricator-form-view-css' => '9094ccaa', 'phabricator-form-view-css' => 'f63b5397',
'phabricator-header-view-css' => '9094ccaa', 'phabricator-header-view-css' => 'f63b5397',
'phabricator-jump-nav' => '9094ccaa', 'phabricator-jump-nav' => 'f63b5397',
'phabricator-keyboard-shortcut' => 'd29c1557', 'phabricator-keyboard-shortcut' => 'd29c1557',
'phabricator-keyboard-shortcut-manager' => 'd29c1557', 'phabricator-keyboard-shortcut-manager' => 'd29c1557',
'phabricator-main-menu-view' => '9094ccaa', 'phabricator-main-menu-view' => 'f63b5397',
'phabricator-menu-item' => 'd29c1557', 'phabricator-menu-item' => 'd29c1557',
'phabricator-nav-view-css' => '9094ccaa', 'phabricator-nav-view-css' => 'f63b5397',
'phabricator-notification' => 'd29c1557', 'phabricator-notification' => 'd29c1557',
'phabricator-notification-css' => '9094ccaa', 'phabricator-notification-css' => 'f63b5397',
'phabricator-notification-menu-css' => '9094ccaa', 'phabricator-notification-menu-css' => 'f63b5397',
'phabricator-object-item-list-view-css' => '9094ccaa', 'phabricator-object-item-list-view-css' => 'f63b5397',
'phabricator-object-selector-css' => '8aaacd1b', 'phabricator-object-selector-css' => '8aaacd1b',
'phabricator-paste-file-upload' => 'd29c1557', 'phabricator-paste-file-upload' => 'd29c1557',
'phabricator-prefab' => 'd29c1557', 'phabricator-prefab' => 'd29c1557',
'phabricator-project-tag-css' => 'e30a3fa8', 'phabricator-project-tag-css' => 'e30a3fa8',
'phabricator-remarkup-css' => '9094ccaa', 'phabricator-remarkup-css' => 'f63b5397',
'phabricator-shaped-request' => 'd2447f72', 'phabricator-shaped-request' => 'd2447f72',
'phabricator-side-menu-view-css' => '9094ccaa', 'phabricator-side-menu-view-css' => 'f63b5397',
'phabricator-standard-page-view' => '9094ccaa', 'phabricator-standard-page-view' => 'f63b5397',
'phabricator-textareautils' => 'd29c1557', 'phabricator-textareautils' => 'd29c1557',
'phabricator-tooltip' => 'd29c1557', 'phabricator-tooltip' => 'd29c1557',
'phabricator-transaction-view-css' => '9094ccaa', 'phabricator-transaction-view-css' => 'f63b5397',
'phabricator-zindex-css' => '9094ccaa', 'phabricator-zindex-css' => 'f63b5397',
'sprite-apps-large-css' => '9094ccaa', 'sprite-apps-large-css' => 'f63b5397',
'sprite-gradient-css' => '9094ccaa', 'sprite-gradient-css' => 'f63b5397',
'sprite-icon-css' => '9094ccaa', 'sprite-icon-css' => 'f63b5397',
'sprite-menu-css' => '9094ccaa', 'sprite-menu-css' => 'f63b5397',
'syntax-highlighting-css' => '9094ccaa', 'syntax-highlighting-css' => 'f63b5397',
), ),
)); ));

View file

@ -179,6 +179,7 @@ final class PhabricatorPropertyListView extends AphrontView {
$classes[] = 'phabricator-property-list-text-content'; $classes[] = 'phabricator-property-list-text-content';
if ($part['type'] == 'image') { if ($part['type'] == 'image') {
$classes[] = 'phabricator-property-list-image-content'; $classes[] = 'phabricator-property-list-image-content';
$classes[] = 'phabricator-remarkup-dark';
} }
return phutil_tag( return phutil_tag(
'div', 'div',

View file

@ -323,3 +323,10 @@
margin: auto; margin: auto;
max-width: 95%; max-width: 95%;
} }
/* phabricator-remarkup-dark assumes a dark backround with light text,
so here are custom rules to override remarkup defaults. */
div.phabricator-remarkup-dark blockquote {
color: #999;
}