revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-15 01:50:55 +01:00
Code Issues Releases Wiki Activity

(stable) Fix an issue where blame could fatal for unrecognized authors

Browse source 
Summary: See PHI255. See <https://discourse.phabricator-community.org/t/error-generating-blame-data/766>.

Test Plan:
  - Viewed a file contributed to by users with no Phabricator user accounts, in Diffusion.
  - Enabled blame.
  - Before patch: blame failed, fatal in logs.
  - After patch: blame worked.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18833
This commit is contained in:
epriestley 2017-12-18 06:26:38 -08:00
parent f56124dc93
commit 563d42d40e
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/applications/diffusion/controller/DiffusionBrowseController.php
View file

@ -1804,10 +1804,17 @@ final class DiffusionBrowseController extends DiffusionController {
// revision. We just render a blank for alignment. // revision. We just render a blank for alignment.
$style = null; $style = null;
$href = null; $href = null;
$sigil = null;
$meta = null;
} else { } else {
$src = $handles[$phid]->getImageURI(); $src = $handles[$phid]->getImageURI();
$style = 'background-image: url('.$src.');'; $style = 'background-image: url('.$src.');';
$href = $handles[$phid]->getURI(); $href = $handles[$phid]->getURI();
$sigil = 'has-tooltip';
$meta = array(
'tip' => $handles[$phid]->getName(),
'align' => 'E',
);
} }
$links[$phid] = javelin_tag( $links[$phid] = javelin_tag(
@ -1816,11 +1823,8 @@ final class DiffusionBrowseController extends DiffusionController {
'class' => 'diffusion-author-link', 'class' => 'diffusion-author-link',
'style' => $style, 'style' => $style,
'href' => $href, 'href' => $href,
'sigil' => 'has-tooltip', 'sigil' => $sigil,
'meta' => array( 'meta' => $meta,
'tip' => $handles[$phid]->getName(),
'align' => 'E',
),
)); ));
} }