Minor touchup on diff banner

Summary: Remove extra icon spacing, swap icons.

Test Plan: Review a diff with comments in sandbox. Try dropdown. Follow links

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D18216

resources/celerity/map.php

@@ -12,8 +12,8 @@ return array(
     'core.pkg.css' => '7ae9e755',
     'core.pkg.js' => '5d80e0db',
     'darkconsole.pkg.js' => '1f9a31bc',
-    'differential.pkg.css' => '4ec4a37a',
-    'differential.pkg.js' => 'd4ab0e81',
+    'differential.pkg.css' => 'b00f573e',
+    'differential.pkg.js' => '1d80ecc6',
     'diffusion.pkg.css' => 'a2d17c7d',
     'diffusion.pkg.js' => '6134c5a1',
     'favicon.ico' => '30672e08',
@@ -64,7 +64,7 @@ return array(
     'rsrc/css/application/dashboard/dashboard.css' => 'fe5b1869',
     'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a',
     'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
-    'rsrc/css/application/differential/changeset-view.css' => 'b5e6be7f',
+    'rsrc/css/application/differential/changeset-view.css' => '3cef17bd',
     'rsrc/css/application/differential/core.css' => '5b7b8ff4',
     'rsrc/css/application/differential/phui-inline-comment.css' => 'ffd1a542',
     'rsrc/css/application/differential/revision-comment.css' => '14b8565a',
@@ -398,7 +398,7 @@ return array(
     'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
     'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
     'rsrc/js/application/diff/DiffChangeset.js' => '99abf4cd',
-    'rsrc/js/application/diff/DiffChangesetList.js' => '79de07c6',
+    'rsrc/js/application/diff/DiffChangesetList.js' => 'cb1570cb',
     'rsrc/js/application/diff/DiffInline.js' => '1bfa31c7',
     'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832',
     'rsrc/js/application/differential/behavior-comment-preview.js' => '51c5ad07',
@@ -564,7 +564,7 @@ return array(
     'conpherence-thread-manager' => '4d863052',
     'conpherence-transaction-css' => '85129c68',
     'd3' => 'a11a5ff2',
-    'differential-changeset-view-css' => 'b5e6be7f',
+    'differential-changeset-view-css' => '3cef17bd',
     'differential-core-view-css' => '5b7b8ff4',
     'differential-revision-add-comment-css' => 'c47f8c40',
     'differential-revision-comment-css' => '14b8565a',
@@ -778,7 +778,7 @@ return array(
     'phabricator-darkmessage' => 'c48cccdd',
     'phabricator-dashboard-css' => 'fe5b1869',
     'phabricator-diff-changeset' => '99abf4cd',
-    'phabricator-diff-changeset-list' => '79de07c6',
+    'phabricator-diff-changeset-list' => 'cb1570cb',
     'phabricator-diff-inline' => '1bfa31c7',
     'phabricator-drag-and-drop-file-upload' => '58dea2fa',
     'phabricator-draggable-list' => 'bea6e7f4',
@@ -1146,6 +1146,9 @@ return array(
       'javelin-util',
       'javelin-uri',
     ),
+    '3cef17bd' => array(
+      'phui-inline-comment-view-css',
+    ),
     '3dbf94d5' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1480,10 +1483,6 @@ return array(
       'javelin-behavior',
       'javelin-quicksand',
     ),
-    '79de07c6' => array(
-      'javelin-install',
-      'phuix-button-view',
-    ),
     '7a68dda3' => array(
       'owners-path-editor',
       'javelin-behavior',
@@ -1815,9 +1814,6 @@ return array(
       'javelin-dom',
       'javelin-util',
     ),
-    'b5e6be7f' => array(
-      'phui-inline-comment-view-css',
-    ),
     'b6993408' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1961,6 +1957,10 @@ return array(
     'cae95e89' => array(
       'syntax-default-css',
     ),
+    'cb1570cb' => array(
+      'javelin-install',
+      'phuix-button-view',
+    ),
     'ccf1cbf8' => array(
       'javelin-install',
       'javelin-dom',

webroot/rsrc/css/application/differential/changeset-view.css

@@ -402,10 +402,6 @@ tr.differential-inline-loading {
   line-height: 28px;
 }
 
-.diff-banner .phui-icon-view {
-  margin-right: 4px;
-}
-
 .diff-banner-path {
   color: {$greytext};
 }

webroot/rsrc/js/application/diff/DiffChangesetList.js

@@ -1610,7 +1610,7 @@ JX.install('DiffChangesetList', {
     _getMenuButton: function() {
       if (!this._menuButton) {
         var button = new JX.PHUIXButtonView()
-          .setIcon('fa-gear')
+          .setIcon('fa-bars')
           .setButtonType(JX.PHUIXButtonView.BUTTONTYPE_SIMPLE);
 
         var dropdown = new JX.PHUIXDropdownMenu(button.getNode());
@@ -1659,7 +1659,7 @@ JX.install('DiffChangesetList', {
 
           list.addItem(
             new JX.PHUIXActionView()
-              .setIcon('fa-link')
+              .setIcon('fa-external-link')
               .setName(pht('List Inline Comments'))
               .setHref(this.getInlineListURI()));
         }