From 56bd762dd3ed5ced1914c6f36fd58dab589ccb31 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 18 Jul 2016 13:06:41 -0700 Subject: [PATCH] Allow file comments to be edited Summary: Fixes T10750. Files have some outdated cache/key code which prevents recording an edit history on file comments. Remove this ancient cruft. (Users must `bin/storage adjust` after upgrading to this patch to reap the benefits.) Test Plan: - Ran `bin/storage adjust`. - Edited a comment in Files. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10750 Differential Revision: https://secure.phabricator.com/D16312 --- .../PhabricatorFileTransactionComment.php | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/applications/files/storage/PhabricatorFileTransactionComment.php b/src/applications/files/storage/PhabricatorFileTransactionComment.php index ee668a49fb..6bada88eac 100644 --- a/src/applications/files/storage/PhabricatorFileTransactionComment.php +++ b/src/applications/files/storage/PhabricatorFileTransactionComment.php @@ -7,20 +7,4 @@ final class PhabricatorFileTransactionComment return new PhabricatorFileTransaction(); } - public function shouldUseMarkupCache($field) { - // Only cache submitted comments. - return ($this->getTransactionPHID() != null); - } - - protected function getConfiguration() { - $config = parent::getConfiguration(); - $config[self::CONFIG_KEY_SCHEMA] = array( - 'key_draft' => array( - 'columns' => array('authorPHID', 'transactionPHID'), - 'unique' => true, - ), - ) + $config[self::CONFIG_KEY_SCHEMA]; - return $config; - } - }