From 578ebe6c2fae3f40b3f0b555581970c9cd6773cd Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 11 Apr 2017 20:08:28 -0700 Subject: [PATCH] Clean up minor form spacing Summary: Drops the inset box shadow and bumps standard UI elements from 28px to 30px. more room for activities. Test Plan: Spaces, Editing tasks, typeaheads, mobile, desktop. {F4897792} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17660 --- resources/celerity/map.php | 14 +++++++------- webroot/rsrc/css/phui/phui-button.css | 8 ++++---- webroot/rsrc/css/phui/phui-comment-form.css | 4 ++-- webroot/rsrc/css/phui/phui-form.css | 8 ++------ 4 files changed, 15 insertions(+), 19 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 488b538f23..37c10ec9a1 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'conpherence.pkg.css' => '82aca405', 'conpherence.pkg.js' => '281b1a73', - 'core.pkg.css' => 'b519db07', + 'core.pkg.css' => '476a4ec7', 'core.pkg.js' => 'fbc1c380', 'darkconsole.pkg.js' => 'e7393ebb', 'differential.pkg.css' => '90b30783', @@ -133,10 +133,10 @@ return array( 'rsrc/css/phui/phui-basic-nav-view.css' => 'a0705f53', 'rsrc/css/phui/phui-big-info-view.css' => 'bd903741', 'rsrc/css/phui/phui-box.css' => '269cbc99', - 'rsrc/css/phui/phui-button.css' => '14bfba79', + 'rsrc/css/phui/phui-button.css' => '96787bae', 'rsrc/css/phui/phui-chart.css' => '6bf6f78e', 'rsrc/css/phui/phui-cms.css' => '504b4b23', - 'rsrc/css/phui/phui-comment-form.css' => '7d903c2d', + 'rsrc/css/phui/phui-comment-form.css' => '57af2e14', 'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad', 'rsrc/css/phui/phui-crumbs-view.css' => '6ece3bbb', 'rsrc/css/phui/phui-curtain-view.css' => '679743bb', @@ -146,7 +146,7 @@ return array( 'rsrc/css/phui/phui-feed-story.css' => '44a9c8e9', 'rsrc/css/phui/phui-fontkit.css' => '1320ed01', 'rsrc/css/phui/phui-form-view.css' => '6175808d', - 'rsrc/css/phui/phui-form.css' => 'b62c01d8', + 'rsrc/css/phui/phui-form.css' => 'a5570f70', 'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f', 'rsrc/css/phui/phui-header-view.css' => '9cf828ce', 'rsrc/css/phui/phui-hovercard.css' => 'ae091fc5', @@ -829,14 +829,14 @@ return array( 'phui-basic-nav-view-css' => 'a0705f53', 'phui-big-info-view-css' => 'bd903741', 'phui-box-css' => '269cbc99', - 'phui-button-css' => '14bfba79', + 'phui-button-css' => '96787bae', 'phui-calendar-css' => '477acfaa', 'phui-calendar-day-css' => '572b1893', 'phui-calendar-list-css' => '576be600', 'phui-calendar-month-css' => '8e10e92c', 'phui-chart-css' => '6bf6f78e', 'phui-cms-css' => '504b4b23', - 'phui-comment-form-css' => '7d903c2d', + 'phui-comment-form-css' => '57af2e14', 'phui-comment-panel-css' => 'f50152ad', 'phui-crumbs-view-css' => '6ece3bbb', 'phui-curtain-view-css' => '679743bb', @@ -846,7 +846,7 @@ return array( 'phui-feed-story-css' => '44a9c8e9', 'phui-font-icon-base-css' => '870a7360', 'phui-fontkit-css' => '1320ed01', - 'phui-form-css' => 'b62c01d8', + 'phui-form-css' => 'a5570f70', 'phui-form-view-css' => '6175808d', 'phui-head-thing-view-css' => 'fd311e5f', 'phui-header-view-css' => '9cf828ce', diff --git a/webroot/rsrc/css/phui/phui-button.css b/webroot/rsrc/css/phui/phui-button.css index 21bf741225..f726487a2d 100644 --- a/webroot/rsrc/css/phui/phui-button.css +++ b/webroot/rsrc/css/phui/phui-button.css @@ -41,7 +41,7 @@ input[type="submit"] { font-weight: bold; font-size: {$normalfontsize}; display: inline-block; - padding: 3px 12px 4px; + padding: 4px 16px 5px; text-align: center; white-space: nowrap; border-radius: 3px; @@ -285,7 +285,7 @@ a.policy-control .phui-button-text { .dropdown .caret { margin-top: 7px; - margin-left: 6px; + margin-right: -4px; } .small.dropdown .caret { @@ -304,8 +304,8 @@ a.policy-control .phui-button-text { .button .phui-icon-view { display: inline-block; position: absolute; - top: 6px; - left: 10px; + top: 7px; + left: 12px; } .button.icon-last .phui-icon-view { diff --git a/webroot/rsrc/css/phui/phui-comment-form.css b/webroot/rsrc/css/phui/phui-comment-form.css index a49d033c3e..860dc9dcaf 100644 --- a/webroot/rsrc/css/phui/phui-comment-form.css +++ b/webroot/rsrc/css/phui/phui-comment-form.css @@ -155,8 +155,8 @@ body.device .phui-box.phui-object-box.phui-comment-form-view { .phui-comment-form-view .phui-form-view label.aphront-form-label, .phui-comment-form-view .phui-form-view .aphront-form-error { - height: 26px; - line-height: 26px; + height: 28x; + line-height: 28px; padding: 0; } diff --git a/webroot/rsrc/css/phui/phui-form.css b/webroot/rsrc/css/phui/phui-form.css index 810ad32c2c..8a6f705ec9 100644 --- a/webroot/rsrc/css/phui/phui-form.css +++ b/webroot/rsrc/css/phui/phui-form.css @@ -20,7 +20,7 @@ input[type="tel"], input[type="color"], div.jx-tokenizer-container { display: inline-block; - height: 28px; + height: 30px; line-height: 18px; color: #333; vertical-align: middle; @@ -49,10 +49,6 @@ div.jx-tokenizer-container { border: 1px solid {$greyborder}; border-radius: 3px; - -webkit-box-shadow: inset 0 1px 1px rgba({$alphablack}, 0.075); - -moz-box-shadow: inset 0 1px 1px rgba({$alphablack}, 0.075); - box-shadow: inset 0 1px 1px rgba({$alphablack}, 0.075); - -webkit-transition: border linear .05s, box-shadow linear .05s; -moz-transition: border linear .05s, box-shadow linear .05s; -o-transition: border linear .05s, box-shadow linear .05s; @@ -114,7 +110,7 @@ select { border-radius: 3px; color: {$darkbluetext}; border: 1px solid {$greyborder}; - height: 28px; + height: 30px; padding: 0 24px 0 8px; margin: 0; min-width: 180px;