From 57e7c7c706c5c69064046d3959c52c460714df62 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Sun, 14 Jun 2015 14:13:15 +1000 Subject: [PATCH] Tidy up some translation strings Summary: Parameterize command names in translation strings. Test Plan: Eyeball it. Reviewers: #blessed_reviewers, epriestley, eadler Reviewed By: #blessed_reviewers, epriestley, eadler Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D13270 --- .../lint/linter/PhabricatorJavelinLinter.php | 4 ++-- .../PhabricatorRemarkupFigletBlockInterpreter.php | 4 +++- .../PhabricatorRemarkupGraphvizBlockInterpreter.php | 7 +++++-- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php b/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php index d235dc889a..ac2957a4af 100644 --- a/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php +++ b/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php @@ -20,8 +20,8 @@ final class PhabricatorJavelinLinter extends ArcanistLinter { public function getInfoDescription() { return pht( 'This linter is intended for use with the Javelin JS library and '. - 'extensions. Use `javelinsymbols` to run Javelin rules on Javascript '. - 'source files.'); + 'extensions. Use `%s` to run Javelin rules on Javascript source files.', + 'javelinsymbols'); } private function getBinaryPath() { diff --git a/src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php b/src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php index 2314b998f3..c1b0d58055 100644 --- a/src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php +++ b/src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php @@ -10,7 +10,9 @@ final class PhabricatorRemarkupFigletBlockInterpreter public function markupContent($content, array $argv) { if (!Filesystem::binaryExists('figlet')) { return $this->markupError( - pht('Unable to locate the `figlet` binary. Install figlet.')); + pht( + 'Unable to locate the `%s` binary. Install figlet.', + 'figlet')); } $font = idx($argv, 'font', 'standard'); diff --git a/src/infrastructure/markup/interpreter/PhabricatorRemarkupGraphvizBlockInterpreter.php b/src/infrastructure/markup/interpreter/PhabricatorRemarkupGraphvizBlockInterpreter.php index d18ebbad10..e06432be6e 100644 --- a/src/infrastructure/markup/interpreter/PhabricatorRemarkupGraphvizBlockInterpreter.php +++ b/src/infrastructure/markup/interpreter/PhabricatorRemarkupGraphvizBlockInterpreter.php @@ -10,7 +10,9 @@ final class PhabricatorRemarkupGraphvizBlockInterpreter public function markupContent($content, array $argv) { if (!Filesystem::binaryExists('dot')) { return $this->markupError( - pht('Unable to locate the `dot` binary. Install Graphviz.')); + pht( + 'Unable to locate the `%s` binary. Install Graphviz.', + 'dot')); } $width = $this->parseDimension(idx($argv, 'width')); @@ -24,7 +26,8 @@ final class PhabricatorRemarkupGraphvizBlockInterpreter if ($err) { return $this->markupError( pht( - 'Execution of `dot` failed (#%d), check your syntax: %s', + 'Execution of `%s` failed (#%d), check your syntax: %s', + 'dot', $err, $stderr)); }