From 58aa3fdc9d44da3afed8e308656c6ba1af5a9c4d Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Fri, 20 May 2016 11:52:14 -0700
Subject: [PATCH] Make View Revision in Mail a little more resilient

Summary: Converts to table so text wraps on long strings well, button always stays top right, better spacing underneath.

Test Plan: Mail, Gmail, mobile

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15955
---
 ...habricatorApplicationTransactionEditor.php | 28 ++++++++-----------
 1 file changed, 12 insertions(+), 16 deletions(-)

diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index 891a6f401c..7570507c9f 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -2730,13 +2730,14 @@ abstract class PhabricatorApplicationTransactionEditor
       $button_style = array(
         'text-decoration: none;',
         'padding: 4px 8px;',
-        'margin: 0 8px;',
+        'margin: 0 8px 8px;',
         'float: right;',
         'color: #464C5C;',
         'font-weight: bold;',
         'border-radius: 3px;',
         'background-color: #F7F7F9;',
         'background-image: linear-gradient(to bottom,#fff,#f1f0f1);',
+        'display: inline-block;',
         'border: 1px solid rgba(71,87,120,.2);',
       );
 
@@ -2750,29 +2751,24 @@ abstract class PhabricatorApplicationTransactionEditor
     }
 
     $xactions_style = array(
-      'padding: 0 0 8px 0;',
     );
 
-    $headers_html = phutil_tag(
-      'div',
+    $header_action = phutil_tag(
+      'td',
+      array(),
+      $header_button);
+
+    $header_action = phutil_tag(
+      'td',
       array(
         'style' => implode(' ', $xactions_style),
       ),
       $headers_html);
 
-    $header_style = array(
-      'overflow: hidden;',
-    );
-
     $headers_html = phutil_tag(
-      'div',
-      array(
-        'style' => implode(' ', $header_style),
-      ),
-      array(
-        $header_button,
-        $headers_html,
-      ));
+      'table',
+      array(),
+      phutil_tag('tr', array(), array($header_action, $header_button)));
 
     $body->addRawHTMLSection($headers_html);