From 58d3f6145a853fe6439014e8b24383ca749da966 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 17 Sep 2020 13:50:24 -0700 Subject: [PATCH] Fix an issue where known Subversion commits are incorrectly shown as "Discovering..." Summary: Ref T13552. The behavior of "RepositoryQuery" with ambiguous identifiers under "withRepositoryPHIDs()" is tricky. This leads to failure to load commits in Subversion in some cases. Use "withRepository()", which gives us the correct identifier resolution behavior. Test Plan: Viewed a subversion repository history in Diffusion, saw commit details after change. Maniphest Tasks: T13552 Differential Revision: https://secure.phabricator.com/D21469 --- src/applications/diffusion/view/DiffusionCommitGraphView.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/diffusion/view/DiffusionCommitGraphView.php b/src/applications/diffusion/view/DiffusionCommitGraphView.php index 2009328a9d..30c252712c 100644 --- a/src/applications/diffusion/view/DiffusionCommitGraphView.php +++ b/src/applications/diffusion/view/DiffusionCommitGraphView.php @@ -614,7 +614,7 @@ final class DiffusionCommitGraphView $commits = id(new DiffusionCommitQuery()) ->setViewer($viewer) - ->withRepositoryPHIDs(array($repository->getPHID())) + ->withRepository($repository) ->withIdentifiers($identifiers) ->needCommitData(true) ->needIdentities(true)