From 58f1c83a5ac56073a1960772c78c99ece72d4729 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Sun, 11 Aug 2024 16:59:32 +0200 Subject: [PATCH] Fix PHP 8.1 "strlen(null)" exception in DivinerFindController Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/diviner/controller/DivinerFindController.php:40] ``` Closes T15910 Test Plan: Go to this (or any other Diviner Find URL not passing a `type` URI parameter): now it works: http://phorge.localhost/diviner/find/?name=PhutilSafeHTML Go to this (or any other Diviner Find URL passing a `type` URI parameter): it still works: http://phorge.localhost/diviner/find/?name=PhutilSafeHTML&type=class Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15910 Differential Revision: https://we.phorge.it/D25768 --- src/applications/diviner/controller/DivinerFindController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/diviner/controller/DivinerFindController.php b/src/applications/diviner/controller/DivinerFindController.php index 2e3b121706..d6ddd420fd 100644 --- a/src/applications/diviner/controller/DivinerFindController.php +++ b/src/applications/diviner/controller/DivinerFindController.php @@ -37,7 +37,7 @@ final class DivinerFindController extends DivinerController { } $type = $request->getStr('type'); - if (strlen($type)) { + if (phutil_nonempty_string($type)) { $query->withTypes(array($type)); }