revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
Code Issues Releases Wiki Activity

Move PhabricatorModularTransaction slightly closer to having "final" methods again

Browse source 
Summary: Depends on D19290. Ref T13110. Differential still has some hacks in place which require these methods to "very temporarily" be nonfinal, but the badness can be slightly reduced nowadays.

Test Plan: Loaded some pages, nothing fataled.

Maniphest Tasks: T13110

Differential Revision: https://secure.phabricator.com/D19291
This commit is contained in:
epriestley 2018-04-03 10:02:19 -07:00
parent 6f520e0534
commit 592d72e006
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/transactions/storage/PhabricatorModularTransaction.php
View file

@ -176,7 +176,7 @@ abstract class PhabricatorModularTransaction
return parent::attachViewer($viewer);
}
/* final */ public function hasChangeDetails() {
final public function hasChangeDetails() {
if ($this->getTransactionImplementation()->hasChangeDetailView()) {
return true;
}
@ -184,7 +184,7 @@ abstract class PhabricatorModularTransaction
return parent::hasChangeDetails();
}
/* final */ public function renderChangeDetails(PhabricatorUser $viewer) {
final public function renderChangeDetails(PhabricatorUser $viewer) {
$impl = $this->getTransactionImplementation();
$impl->setViewer($viewer);
$view = $impl->newChangeDetailView();