Make Phabricator clone bare git repositories

Summary:
This doesn't really impact anything very much, but is a little cleaner than cloning repositories with a working copy. It's somewhat important for allowing pushes, because you can't push to a checked-out branch.

Mercurial has a similar option (`--noupdate`) but leave that alone for now.

The origin stuff was mostly for sanity/explicitness purposes -- I believe it's safe to remove in all non-ridiculous cases. Git fails with it in bare repositories (it automatically creates an `origin`, but doesn't create the local refs for it, or something).

Test Plan: Nuked a repo, re-cloned it, pulled and updated it several times. Browsed both bare and non-bare repos in Diffusion.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2230

Differential Revision: https://secure.phabricator.com/D7430

src/applications/diffusion/controller/DiffusionRepositoryController.php

@@ -40,6 +40,7 @@ final class DiffusionRepositoryController extends DiffusionController {
           }
         }
       }
+      $history_exception = null;
     } catch (Exception $ex) {
       $history_results = null;
       $history = null;
@@ -68,6 +69,7 @@ final class DiffusionRepositoryController extends DiffusionController {
         }
       }
 
+      $browse_exception = null;
     } catch (Exception $ex) {
       $browse_results = null;
       $browse_paths = null;

src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php

@@ -37,8 +37,12 @@ final class DiffusionRepositoryEditBranchesController
     $edit_uri = $this->getRepositoryControllerURI($repository, 'edit/');
 
     $v_default = $repository->getHumanReadableDetail('default-branch');
-    $v_track = $repository->getHumanReadableDetail('branch-filter');
+    $v_track = $repository->getHumanReadableDetail(
-    $v_autoclose = $repository->getHumanReadableDetail('close-commits-filter');
+      'branch-filter',
+      array());
+    $v_autoclose = $repository->getHumanReadableDetail(
+      'close-commits-filter',
+      array());
 
     if ($request->isFormPost()) {
       $v_default = $request->getStr('default');

src/applications/diffusion/query/stablecommitname/DiffusionGitStableCommitNameQuery.php

@@ -7,8 +7,7 @@ extends DiffusionStableCommitNameQuery {
     $repository = $this->getRepository();
     $branch = $this->getBranch();
     list($stdout) = $repository->execxLocalCommand(
-      'rev-parse --verify %s/%s',
+      'rev-parse --verify %s',
-      DiffusionBranchInformation::DEFAULT_GIT_REMOTE,
       $branch);
 
     $commit = trim($stdout);

src/applications/diffusion/request/DiffusionGitRequest.php

@@ -31,8 +31,7 @@ final class DiffusionGitRequest extends DiffusionRequest {
     if ($this->commit) {
       return $this->commit;
     }
-    $remote = DiffusionBranchInformation::DEFAULT_GIT_REMOTE;
+    return $this->getBranch();
-    return $remote.'/'.$this->getBranch();
   }
 
 }

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

@@ -99,7 +99,7 @@ final class PhabricatorRepositoryPullEngine
     $repository = $this->getRepository();
 
     $repository->execxRemoteCommand(
-      'clone --origin origin %s %s',
+      'clone --bare %s %s',
       $repository->getRemoteURI(),
       rtrim($repository->getLocalPath(), '/'));
   }
@@ -149,12 +149,11 @@ final class PhabricatorRepositoryPullEngine
       $repo_path = rtrim($stdout, "\n");
 
       if (empty($repo_path)) {
-        $err = true;
+        // This can mean one of two things: we're in a bare repository, or
-        $message =
+        // we're inside a git repository inside another git repository. Since
-          "Expected to find a git repository at '{$path}', but ".
+        // the first is dramatically more likely now that we perform bare
-          "there was no result from `git rev-parse --show-toplevel`. ".
+        // clones and I don't have a great way to test for the latter, assume
-          "Something is misconfigured or broken. The git repository ".
+        // we're OK.
-          "may be inside a '.git/' directory.";
       } else if (!Filesystem::pathsAreEquivalent($repo_path, $path)) {
         $err = true;
         $message =

src/applications/repository/engine/__tests__/PhabricatorWorkingCopyPullTestCase.php

@@ -8,7 +8,7 @@ final class PhabricatorWorkingCopyPullTestCase
 
     $this->assertEqual(
       true,
-      Filesystem::pathExists($repo->getLocalPath().'/.git'));
+      Filesystem::pathExists($repo->getLocalPath().'/HEAD'));
   }
 
   public function testHgPullBasic() {