From 59e71b11569101cefed91df6f211d25a69f56c7e Mon Sep 17 00:00:00 2001 From: jungejason Date: Mon, 7 Mar 2011 11:05:05 -0800 Subject: [PATCH] Improve error message about missing certificate. Summary: improve the error message by adding reference to documentation. Test Plan: remove the certificate in .arcrc and run arc diff to see if the improved error message shows up. Reviewers: epriestley CC: Differential Revision: 53 --- .../controller/api/PhabricatorConduitAPIController.php | 6 +++++- .../conduit/connect/ConduitAPI_conduit_connect_Method.php | 4 +++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/applications/conduit/controller/api/PhabricatorConduitAPIController.php b/src/applications/conduit/controller/api/PhabricatorConduitAPIController.php index 67a56a3d35..c68a4932d5 100644 --- a/src/applications/conduit/controller/api/PhabricatorConduitAPIController.php +++ b/src/applications/conduit/controller/api/PhabricatorConduitAPIController.php @@ -91,7 +91,11 @@ class PhabricatorConduitAPIController $auth_okay = false; $error_code = 'ERR-NO-CERTIFICATE'; $error_info = "This server requires authentication but your client ". - "is not configured with an authentication certificate."; + "is not configured with an authentication ". + "certificate. Please refer to ". + "page http://www.phabricator.com/docs/". + "phabricator/article/". + "Installing_Arcanist_Certificates.html for more info."; } else { $user = new PhabricatorUser(); $session = queryfx_one( diff --git a/src/applications/conduit/method/conduit/connect/ConduitAPI_conduit_connect_Method.php b/src/applications/conduit/method/conduit/connect/ConduitAPI_conduit_connect_Method.php index 8154fb5aaa..5562cbdb5a 100644 --- a/src/applications/conduit/method/conduit/connect/ConduitAPI_conduit_connect_Method.php +++ b/src/applications/conduit/method/conduit/connect/ConduitAPI_conduit_connect_Method.php @@ -63,7 +63,9 @@ class ConduitAPI_conduit_connect_Method extends ConduitAPIMethod { "you're executing a replay attack.", "ERR-NO-CERTIFICATE" => "This server requires authentication but your client is not ". - "configured with an authentication certificate." + "configured with an authentication certificate. Please refer to page ". + "http://www.phabricator.com/docs/phabricator/article/". + "Installing_Arcanist_Certificates.html for more info." ); }