Update Meta for new UI

Summary: Runs through Meta, cleaned up policies and editing email addresses to new UI

Test Plan: Set a new Email address for Maniphest, edit policies.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15569

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

@@ -123,8 +123,7 @@ final class PhabricatorApplicationDetailViewController
     PhabricatorApplication $application) {
 
     $viewer = $this->getViewer();
-    $properties = id(new PHUIPropertyListView())
+    $properties = id(new PHUIPropertyListView());
-      ->setStacked(true);
 
     $header = id(new PHUIHeaderView())
       ->setHeader(pht('POLICIES'))

src/applications/meta/controller/PhabricatorApplicationEditController.php

@@ -171,22 +171,27 @@ final class PhabricatorApplicationEditController
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addTextCrumb($application->getName(), $view_uri);
     $crumbs->addTextCrumb(pht('Edit Policies'));
+    $crumbs->setBorder(true);
 
     $header = id(new PHUIHeaderView())
-      ->setHeader(pht('Edit Policies: %s', $application->getName()));
+      ->setHeader(pht('Edit Policies: %s', $application->getName()))
+      ->setHeaderIcon('fa-pencil');
 
     $object_box = id(new PHUIObjectBoxView())
-      ->setHeader($header)
+      ->setHeaderText(pht('Policies'))
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->setForm($form);
 
-    return $this->buildApplicationPage(
+    $view = id(new PHUITwoColumnView())
-      array(
+      ->setHeader($header)
-        $crumbs,
+      ->setFooter(array(
         $object_box,
-      ),
-      array(
-        'title' => $title,
       ));
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild($view);
   }
 
 }

src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php

@@ -137,14 +137,10 @@ final class PhabricatorApplicationEmailCommandsController
       ->appendChild($info_view)
       ->appendChild($content_box);
 
-    return $this->buildApplicationPage(
+    return $this->newPage()
-      array(
+      ->setTitle($title)
-        $crumbs,
+      ->setCrumbs($crumbs)
-        $document,
+      ->appendChild($document);
-      ),
-      array(
-        'title' => $title,
-      ));
 
   }
 

src/applications/meta/controller/PhabricatorApplicationPanelController.php

@@ -59,9 +59,14 @@ final class PhabricatorApplicationPanelController
 
   public function buildPanelPage(
     PhabricatorApplicationConfigurationPanel $panel,
-    $content,
+    $title,
-    array $options) {
+    $crumbs,
-    return $this->buildApplicationPage($content, $options);
+    $content) {
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild($content);
   }
 
 }

src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php

@@ -37,6 +37,7 @@ final class PhabricatorMetaMTAApplicationEmailPanel
 
     $box = id(new PHUIObjectBoxView())
       ->setHeader($header)
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->setTable($table);
 
     return $box;
@@ -81,10 +82,12 @@ final class PhabricatorMetaMTAApplicationEmailPanel
 
     $crumbs = $controller->buildPanelCrumbs($this);
     $crumbs->addTextCrumb(pht('Edit Application Emails'));
+    $crumbs->setBorder(true);
 
     $header = id(new PHUIHeaderView())
       ->setHeader(pht('Edit Application Emails: %s', $application->getName()))
-      ->setSubheader($application->getAppEmailBlurb());
+      ->setSubheader($application->getAppEmailBlurb())
+      ->setHeaderIcon('fa-pencil');
 
     $icon = id(new PHUIIconView())
       ->setIcon('fa-plus');
@@ -97,20 +100,20 @@ final class PhabricatorMetaMTAApplicationEmailPanel
     $header->addActionLink($button);
 
     $object_box = id(new PHUIObjectBoxView())
-      ->setHeader($header)
+      ->setHeaderText(pht('Emails'))
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->setTable($table);
 
     $title = $application->getName();
+    $view = id(new PHUITwoColumnView())
+      ->setHeader($header)
+      ->setFooter($object_box);
 
     return $controller->buildPanelPage(
       $this,
-      array(
+      $title,
       $crumbs,
-        $object_box,
+      $view);
-      ),
-      array(
-        'title' => $title,
-      ));
   }
 
   private function returnNewAddressResponse(