mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-26 00:32:42 +01:00
Fix PHP 8.1 "strlen(null)" exception which blocks rendering creation form pages for Legalpad, Macro, Settings
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Closes T15309 Test Plan: Applied this change (on top of `D25144`, `D25145`, `D25146`, `D25147`, `D25150`, `D25151`, `D25152`, `D25153`, `D25154`, `D25155`, `D25156`, `D25158` locally applied) and the pages `/legalpad/edit/`, `/macro/create/`, `/settings/builtin/global/` rendered in web browser. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15309 Differential Revision: https://we.phorge.it/D25159
This commit is contained in:
parent
d8d45d343e
commit
5a0d82df7f
1 changed files with 1 additions and 1 deletions
|
@ -941,7 +941,7 @@ abstract class PhabricatorEditEngine
|
|||
}
|
||||
} else {
|
||||
$form_key = $request->getURIData('formKey');
|
||||
if (strlen($form_key)) {
|
||||
if (phutil_nonempty_string($form_key)) {
|
||||
$config = $this->loadEditEngineConfigurationWithIdentifier($form_key);
|
||||
|
||||
if (!$config) {
|
||||
|
|
Loading…
Reference in a new issue