revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 21:02:41 +01:00
Code Issues Releases Wiki Activity

Fix header tag on Hovercards

Browse source 
Summary: Switch to new method.

Test Plan: Hover over task, see tag in correct place.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15403
This commit is contained in:
Chad Little 2016-03-05 15:25:06 +00:00 committed by chad
parent fec1a154d5
commit 5a43e2040e
5 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -7,7 +7,7 @@
*/ */
return array( return array(
'names' => array( 'names' => array(
'core.pkg.css' => 'c0f196d2', 'core.pkg.css' => '3d58b25a',
'core.pkg.js' => '7d8faf57', 'core.pkg.js' => '7d8faf57',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '2de124c9', 'differential.pkg.css' => '2de124c9',
@ -135,7 +135,7 @@ return array(
'rsrc/css/phui/phui-form-view.css' => '4a1a0f5e', 'rsrc/css/phui/phui-form-view.css' => '4a1a0f5e',
'rsrc/css/phui/phui-form.css' => 'aac1d51d', 'rsrc/css/phui/phui-form.css' => 'aac1d51d',
'rsrc/css/phui/phui-head-thing.css' => '11731da0', 'rsrc/css/phui/phui-head-thing.css' => '11731da0',
'rsrc/css/phui/phui-header-view.css' => '32e71367', 'rsrc/css/phui/phui-header-view.css' => '26cffd3d',
'rsrc/css/phui/phui-hovercard.css' => 'de1a2119', 'rsrc/css/phui/phui-hovercard.css' => 'de1a2119',
'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad', 'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad',
'rsrc/css/phui/phui-icon.css' => '3f33ab57', 'rsrc/css/phui/phui-icon.css' => '3f33ab57',
@ -820,7 +820,7 @@ return array(
'phui-form-css' => 'aac1d51d', 'phui-form-css' => 'aac1d51d',
'phui-form-view-css' => '4a1a0f5e', 'phui-form-view-css' => '4a1a0f5e',
'phui-head-thing-view-css' => '11731da0', 'phui-head-thing-view-css' => '11731da0',
'phui-header-view-css' => '32e71367', 'phui-header-view-css' => '26cffd3d',
'phui-hovercard' => '1bd28176', 'phui-hovercard' => '1bd28176',
'phui-hovercard-view-css' => 'de1a2119', 'phui-hovercard-view-css' => 'de1a2119',
'phui-icon-set-selector-css' => '1ab67aad', 'phui-icon-set-selector-css' => '1ab67aad',

3
src/applications/passphrase/controller/PassphraseCredentialViewController.php
View file

@ -59,7 +59,8 @@ final class PassphraseCredentialViewController extends PassphraseController {
$header = id(new PHUIHeaderView()) $header = id(new PHUIHeaderView())
->setUser($viewer) ->setUser($viewer)
->setHeader($credential->getName()) ->setHeader($credential->getName())
->setPolicyObject($credential); ->setPolicyObject($credential)
->setHeaderIcon('fa-user-secret');
if ($credential->getIsDestroyed()) { if ($credential->getIsDestroyed()) {
$header->setStatus('fa-ban', 'red', pht('Destroyed')); $header->setStatus('fa-ban', 'red', pht('Destroyed'));

3
src/applications/paste/controller/PhabricatorPasteViewController.php
View file

@ -110,7 +110,8 @@ final class PhabricatorPasteViewController extends PhabricatorPasteController {
->setHeader($title) ->setHeader($title)
->setUser($this->getRequest()->getUser()) ->setUser($this->getRequest()->getUser())
->setStatus($header_icon, $header_color, $header_name) ->setStatus($header_icon, $header_color, $header_name)
->setPolicyObject($paste); ->setPolicyObject($paste)
->setHeaderIcon('fa-clipboard');
return $header; return $header;
} }

2
src/view/phui/PHUIHovercardView.php
View file

@ -106,7 +106,7 @@ final class PHUIHovercardView extends AphrontTagView {
$header->setHeader($title); $header->setHeader($title);
if ($this->tags) { if ($this->tags) {
foreach ($this->tags as $tag) { foreach ($this->tags as $tag) {
$header->addTag($tag); $header->addActionItem($tag);
} }
} }

4
webroot/rsrc/css/phui/phui-header-view.css
View file

@ -175,6 +175,10 @@ body .phui-header-shell.phui-bleed-header
margin-top: 8px; margin-top: 8px;
} }
.phui-header-subheader .phui-icon-view {
margin-right: 4px;
}
.phui-header-subheader .phui-tag-view .phui-icon-view, .phui-header-subheader .phui-tag-view .phui-icon-view,
.phui-header-subheader .policy-header-callout .phui-icon-view { .phui-header-subheader .policy-header-callout .phui-icon-view {
display: inline-block; display: inline-block;