From 5ae3af6691caa5d85cadf5f12e4ee845cf285988 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 15 Sep 2017 05:33:08 -0700 Subject: [PATCH] Fix an outdated HTML anchor link in Diffusion table of contents Summary: See . In D18465, I updated these but this hard-coded the anchor for some reason (???) and I missed it while `grep`-ing. Test Plan: Viewed a commit (`/rXYZaaaa`) and clicked a file link in the table of contents. Got modern `#change-...` anchor and navigation into the document. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D18609 --- .../diffusion/controller/DiffusionCommitController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php index 554ad64e5e..59a132b17d 100644 --- a/src/applications/diffusion/controller/DiffusionCommitController.php +++ b/src/applications/diffusion/controller/DiffusionCommitController.php @@ -946,7 +946,7 @@ final class DiffusionCommitController extends DiffusionController { foreach ($changesets as $changeset_id => $changeset) { $path = $changeset->getFilename(); - $anchor = substr(md5($path), 0, 8); + $anchor = $changeset->getAnchorName(); $history_link = $diffusion_view->linkHistory($path); $browse_link = $diffusion_view->linkBrowse(