revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-12 07:41:04 +01:00
Code Issues Releases Wiki Activity

differntial and diffusion design tweaks

Browse source 
Summary: most awesome is that differential-primary-pane no longer has a place in diffusion. less awesome is fixing the zebra striping on differential "Local Commits" view and making the font size of one of the table headers match the others.

Test Plan: looks good!

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4177
This commit is contained in:
Bob Trahan 2012-12-13 10:46:41 -08:00
parent 406833ba90
commit 5b15f725bd
5 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/applications/differential/view/DifferentialLocalCommitsView.php
View file

@ -41,7 +41,16 @@ final class DifferentialLocalCommitsView extends AphrontView {
} }
$rows = array(); $rows = array();
$highlight = true;
foreach ($local as $commit) { foreach ($local as $commit) {
if ($highlight) {
$class = 'alt';
$highlight = false;
} else {
$class = '';
$highlight = true;
}
$row = array(); $row = array();
if (idx($commit, 'commit')) { if (idx($commit, 'commit')) {
@ -106,7 +115,7 @@ final class DifferentialLocalCommitsView extends AphrontView {
} }
$row[] = '<td>'.$date.'</td>'; $row[] = '<td>'.$date.'</td>';
$rows[] = '<tr>'.implode('', $row).'</tr>'; $rows[] = '<tr class="'.$class.'">'.implode('', $row).'</tr>';
} }

5
src/applications/diffusion/controller/DiffusionChangeController.php
View file

@ -51,10 +51,7 @@ final class DiffusionChangeController extends DiffusionController {
// TODO: This is pretty awkward, unify the CSS between Diffusion and // TODO: This is pretty awkward, unify the CSS between Diffusion and
// Differential better. // Differential better.
require_celerity_resource('differential-core-view-css'); require_celerity_resource('differential-core-view-css');
$content[] = $content[] = $changeset_view->render();
'<div class="differential-primary-pane">'.
$changeset_view->render().
'</div>';
$nav = $this->buildSideNav('change', true); $nav = $this->buildSideNav('change', true);
$nav->appendChild($content); $nav->appendChild($content);

1
src/applications/diffusion/controller/DiffusionCommitController.php
View file

@ -301,7 +301,6 @@ final class DiffusionCommitController extends DiffusionController {
$main_pane = phutil_render_tag( $main_pane = phutil_render_tag(
'div', 'div',
array( array(
'class' => 'differential-primary-pane',
'id' => $pane_id 'id' => $pane_id
), ),
$change_list->render(). $change_list->render().

2
webroot/rsrc/css/application/differential/local-commits-view.css
View file

@ -14,7 +14,7 @@
padding: 4px 6px; padding: 4px 6px;
} }
.differential-local-commits-table tr td { .differential-local-commits-table tr.alt td {
background: #dcdcdc; background: #dcdcdc;
} }

3
webroot/rsrc/css/application/differential/revision-history.css
View file

@ -9,8 +9,9 @@
} }
.differential-revision-history-table th { .differential-revision-history-table th {
padding: 0 .5em;
color: #666666; color: #666666;
font-size: 11px;
padding: 0 .5em;
} }
.differential-revision-history-table td { .differential-revision-history-table td {