differntial and diffusion design tweaks

Summary: most awesome is that differential-primary-pane no longer has a place in diffusion. less awesome is fixing the zebra striping on differential "Local Commits" view and making the font size of one of the table headers match the others.

Test Plan: looks good!

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4177

src/applications/differential/view/DifferentialLocalCommitsView.php

@@ -41,7 +41,16 @@ final class DifferentialLocalCommitsView extends AphrontView {
     }
 
     $rows = array();
+    $highlight = true;
     foreach ($local as $commit) {
+      if ($highlight) {
+        $class = 'alt';
+        $highlight = false;
+      } else {
+        $class = '';
+        $highlight = true;
+      }
+
 
       $row = array();
       if (idx($commit, 'commit')) {
@@ -106,7 +115,7 @@ final class DifferentialLocalCommitsView extends AphrontView {
       }
       $row[] = '<td>'.$date.'</td>';
 
-      $rows[] = '<tr>'.implode('', $row).'</tr>';
+      $rows[] = '<tr class="'.$class.'">'.implode('', $row).'</tr>';
     }
 
 

src/applications/diffusion/controller/DiffusionChangeController.php

@@ -51,10 +51,7 @@ final class DiffusionChangeController extends DiffusionController {
     // TODO: This is pretty awkward, unify the CSS between Diffusion and
     // Differential better.
     require_celerity_resource('differential-core-view-css');
-    $content[] =
-      '<div class="differential-primary-pane">'.
-        $changeset_view->render().
-      '</div>';
+    $content[] = $changeset_view->render();
 
     $nav = $this->buildSideNav('change', true);
     $nav->appendChild($content);

src/applications/diffusion/controller/DiffusionCommitController.php

@@ -301,7 +301,6 @@ final class DiffusionCommitController extends DiffusionController {
       $main_pane = phutil_render_tag(
         'div',
         array(
-          'class' => 'differential-primary-pane',
           'id'    => $pane_id
         ),
         $change_list->render().

webroot/rsrc/css/application/differential/local-commits-view.css

@@ -14,7 +14,7 @@
   padding: 4px 6px;
 }
 
-.differential-local-commits-table tr td {
+.differential-local-commits-table tr.alt td {
   background: #dcdcdc;
 }
 

webroot/rsrc/css/application/differential/revision-history.css

@@ -9,8 +9,9 @@
 }
 
 .differential-revision-history-table th {
-  padding: 0 .5em;
   color: #666666;
+  font-size: 11px;
+  padding: 0 .5em;
 }
 
 .differential-revision-history-table td {