revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Remove "metamta.precedence-bulk" option (always enable it)

Browse source 
Summary: Ref T7746. This might possibly improve deliverability. Or might make it worse. Who knows?

Test Plan: `grep`

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7746

Differential Revision: https://secure.phabricator.com/D12266
This commit is contained in:
epriestley 2015-04-03 16:38:27 -07:00
parent d8ab19a166
commit 5b1d0f9ed7
3 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
View file

@ -241,6 +241,10 @@ final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
'metamta.differential.reply-handler' => $reply_handler_reason, 'metamta.differential.reply-handler' => $reply_handler_reason,
'metamta.maniphest.reply-handler' => $reply_handler_reason, 'metamta.maniphest.reply-handler' => $reply_handler_reason,
'metamta.package.reply-handler' => $reply_handler_reason, 'metamta.package.reply-handler' => $reply_handler_reason,
'metamta.precedence-bulk' => pht(
'Phabricator now always sends transaction mail with '.
'"Precedence: bulk" to improve deliverability.'),
); );
return $ancient_config; return $ancient_config;

8
src/applications/config/option/PhabricatorMetaMTAConfigOptions.php
View file

@ -271,14 +271,6 @@ EODOC
)) ))
->setSummary(pht('Show email preferences link in email.')) ->setSummary(pht('Show email preferences link in email.'))
->setDescription($email_preferences_description), ->setDescription($email_preferences_description),
$this->newOption('metamta.precedence-bulk', 'bool', false)
->setBoolOptions(
array(
pht('Add "Precedence: bulk" Header'),
pht('No "Precedence: bulk" Header'),
))
->setSummary(pht('Control the "Precedence: bulk" header.'))
->setDescription($bulk_description),
$this->newOption('metamta.re-prefix', 'bool', false) $this->newOption('metamta.re-prefix', 'bool', false)
->setBoolOptions( ->setBoolOptions(
array( array(

4
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
View file

@ -545,9 +545,7 @@ final class PhabricatorMetaMTAMail extends PhabricatorMetaMTADAO {
break; break;
case 'is-bulk': case 'is-bulk':
if ($value) { if ($value) {
if (PhabricatorEnv::getEnvConfig('metamta.precedence-bulk')) { $mailer->addHeader('Precedence', 'bulk');
$mailer->addHeader('Precedence', 'bulk');
}
} }
break; break;
case 'thread-id': case 'thread-id':