revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 01:08:50 +02:00
Code Issues Releases Wiki Activity

Correct issue with "bindings" conduit attachment

Browse source 
Summary: Ref T13641. These conditions are swapped, and "activeBindings" loads more data than necessary while "bindings" doesn't load enough.

Test Plan: Called method with each attachment, got good results instead of an exception.

Maniphest Tasks: T13641

Differential Revision: https://secure.phabricator.com/D21657
This commit is contained in:
epriestley 2021-03-27 09:16:12 -07:00
parent 61272e7ac3
commit 5b8b5f2141
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/almanac/engineextension/AlmanacBindingsSearchEngineAttachment.php
View file

@ -26,9 +26,9 @@ final class AlmanacBindingsSearchEngineAttachment
$query->needProperties(true); $query->needProperties(true);
if ($this->getIsActive()) { if ($this->getIsActive()) {
$query->needBindings(true);
} else {
$query->needActiveBindings(true); $query->needActiveBindings(true);
} else {
$query->needBindings(true);
} }
} }