revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

Fix two issues with callsign-free repositories

Browse source 
Summary:
Ref T4245. These callsites don't quite do the right thing if a repository has no callsign.

See also <https://github.com/phacility/phabricator/pull/822>.

Test Plan: Made a comment on a commit in a repository with no callsign.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4245

Differential Revision: https://secure.phabricator.com/D15344
This commit is contained in:
epriestley 2016-02-25 03:07:47 -08:00
parent 944539a786
commit 5b9d8aeae7
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/audit/controller/PhabricatorAuditAddCommentController.php
View file

@ -82,9 +82,7 @@ final class PhabricatorAuditAddCommentController
$draft->delete(); $draft->delete();
} }
$monogram = $commit->getRepository()->getMonogram(); $uri = $commit->getURI();
$identifier = $commit->getCommitIdentifier();
$uri = '/'.$monogram.$identifier;
return id(new AphrontRedirectResponse())->setURI($uri); return id(new AphrontRedirectResponse())->setURI($uri);
} }

2
src/applications/diffusion/controller/DiffusionExternalController.php
View file

@ -103,7 +103,7 @@ final class DiffusionExternalController extends DiffusionController {
array( array(
'href' => $href, 'href' => $href,
), ),
$commit->getMonogram()), $commit->getURI()),
$commit->loadCommitData()->getSummary(), $commit->loadCommitData()->getSummary(),
); );
} }