From 5bde6c71ce4ea2650ee52febc705999e1dd5a4bd Mon Sep 17 00:00:00 2001 From: vrana Date: Thu, 4 Oct 2012 14:33:50 -0700 Subject: [PATCH] Declare used properties Summary: Also fix couple of other errors. Test Plan: Executed controllers. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3627 --- .../AphrontDefaultApplicationConfiguration.php | 5 ----- .../controller/PhabricatorOAuthDiagnosticsController.php | 2 ++ .../controller/PhabricatorCountdownDeleteController.php | 2 ++ src/applications/herald/storage/HeraldRule.php | 2 ++ src/applications/herald/view/HeraldRuleEditHistoryView.php | 1 + src/applications/ponder/controller/PonderFeedController.php | 5 ----- src/applications/ponder/view/PonderUserProfileView.php | 6 ------ .../controller/PhabricatorProjectMembersEditController.php | 2 ++ .../controller/PhabricatorProjectProfileEditController.php | 2 ++ .../controller/PhabricatorXHPASTViewPanelController.php | 4 ++-- src/view/layout/PhabricatorPinboardItemView.php | 2 ++ 11 files changed, 15 insertions(+), 18 deletions(-) diff --git a/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php b/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php index a4d70c2bb7..ee3153d748 100644 --- a/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php +++ b/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php @@ -121,11 +121,6 @@ class AphrontDefaultApplicationConfiguration '' => 'DrydockResourceListController', 'resource/' => 'DrydockResourceListController', 'resource/allocate/' => 'DrydockResourceAllocateController', - 'host/' => array( - '' => 'DrydockHostListController', - 'edit/' => 'DrydockHostEditController', - 'edit/(?P\d+)/' => 'DrydockhostEditController', - ), 'lease/' => 'DrydockLeaseListController', 'log/' => 'DrydockLogController', ), diff --git a/src/applications/auth/controller/PhabricatorOAuthDiagnosticsController.php b/src/applications/auth/controller/PhabricatorOAuthDiagnosticsController.php index ec9add8a23..e4bf3835a4 100644 --- a/src/applications/auth/controller/PhabricatorOAuthDiagnosticsController.php +++ b/src/applications/auth/controller/PhabricatorOAuthDiagnosticsController.php @@ -19,6 +19,8 @@ final class PhabricatorOAuthDiagnosticsController extends PhabricatorAuthController { + private $provider; + public function shouldRequireLogin() { return false; } diff --git a/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php b/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php index 6798c4f819..7981ac7973 100644 --- a/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php +++ b/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php @@ -19,6 +19,8 @@ final class PhabricatorCountdownDeleteController extends PhabricatorCountdownController { + private $id; + public function willProcessRequest(array $data) { $this->id = $data['id']; } diff --git a/src/applications/herald/storage/HeraldRule.php b/src/applications/herald/storage/HeraldRule.php index 87d0592c29..f03326a84e 100644 --- a/src/applications/herald/storage/HeraldRule.php +++ b/src/applications/herald/storage/HeraldRule.php @@ -32,6 +32,8 @@ final class HeraldRule extends HeraldDAO { private $ruleApplied = array(); // phids for which this rule has been applied private $invalidOwner = false; + private $conditions; + private $actions; public static function loadAllByContentTypeWithFullData( $content_type, diff --git a/src/applications/herald/view/HeraldRuleEditHistoryView.php b/src/applications/herald/view/HeraldRuleEditHistoryView.php index e8545e6003..a6c5c574dc 100644 --- a/src/applications/herald/view/HeraldRuleEditHistoryView.php +++ b/src/applications/herald/view/HeraldRuleEditHistoryView.php @@ -20,6 +20,7 @@ final class HeraldRuleEditHistoryView extends AphrontView { private $edits; private $handles; + private $user; public function setEdits(array $edits) { $this->edits = $edits; diff --git a/src/applications/ponder/controller/PonderFeedController.php b/src/applications/ponder/controller/PonderFeedController.php index 67a744a47b..952ee998c8 100644 --- a/src/applications/ponder/controller/PonderFeedController.php +++ b/src/applications/ponder/controller/PonderFeedController.php @@ -24,7 +24,6 @@ final class PonderFeedController extends PonderController { public function willProcessRequest(array $data) { $this->page = idx($data, 'page'); - $this->feedOffset = idx($data, 'feedoffset'); } public function processRequest() { @@ -81,14 +80,10 @@ final class PonderFeedController extends PonderController { self::PROFILE_ANSWER_PAGE_SIZE + 1 ); - $phids = array($user->getPHID()); - $handles = $this->loadViewerHandles($phids); - $side_nav->appendChild( id(new PonderUserProfileView()) ->setUser($user) ->setAnswers($answers) - ->setHandles($handles) ->setAnswerOffset($this->answerOffset) ->setPageSize(self::PROFILE_ANSWER_PAGE_SIZE) ->setURI(new PhutilURI("/ponder/profile/"), "aoff") diff --git a/src/applications/ponder/view/PonderUserProfileView.php b/src/applications/ponder/view/PonderUserProfileView.php index 8a611b36d4..c0a6109ece 100644 --- a/src/applications/ponder/view/PonderUserProfileView.php +++ b/src/applications/ponder/view/PonderUserProfileView.php @@ -50,11 +50,6 @@ final class PonderUserProfileView extends AphrontView { return $this; } - public function setHandles($handles) { - $this->handles = $handles; - return $this; - } - public function setURI($uri, $aparam) { $this->uri = $uri; $this->aparam = $aparam; @@ -68,7 +63,6 @@ final class PonderUserProfileView extends AphrontView { $user = $this->user; $aoffset = $this->answeroffset; $answers = $this->answers; - $handles = $this->handles; $uri = $this->uri; $aparam = $this->aparam; $pagesize = $this->pagesize; diff --git a/src/applications/project/controller/PhabricatorProjectMembersEditController.php b/src/applications/project/controller/PhabricatorProjectMembersEditController.php index a6b8125a9b..f2dcae0482 100644 --- a/src/applications/project/controller/PhabricatorProjectMembersEditController.php +++ b/src/applications/project/controller/PhabricatorProjectMembersEditController.php @@ -19,6 +19,8 @@ final class PhabricatorProjectMembersEditController extends PhabricatorProjectController { + private $id; + public function willProcessRequest(array $data) { $this->id = $data['id']; } diff --git a/src/applications/project/controller/PhabricatorProjectProfileEditController.php b/src/applications/project/controller/PhabricatorProjectProfileEditController.php index 8da592b910..a288cd735d 100644 --- a/src/applications/project/controller/PhabricatorProjectProfileEditController.php +++ b/src/applications/project/controller/PhabricatorProjectProfileEditController.php @@ -19,6 +19,8 @@ final class PhabricatorProjectProfileEditController extends PhabricatorProjectController { + private $id; + public function willProcessRequest(array $data) { $this->id = $data['id']; } diff --git a/src/applications/xhpastview/controller/PhabricatorXHPASTViewPanelController.php b/src/applications/xhpastview/controller/PhabricatorXHPASTViewPanelController.php index 25bcd23082..84d2a0f079 100644 --- a/src/applications/xhpastview/controller/PhabricatorXHPASTViewPanelController.php +++ b/src/applications/xhpastview/controller/PhabricatorXHPASTViewPanelController.php @@ -1,7 +1,7 @@ id = $data['id']; diff --git a/src/view/layout/PhabricatorPinboardItemView.php b/src/view/layout/PhabricatorPinboardItemView.php index f3325c4fc0..89b8d1c7fd 100644 --- a/src/view/layout/PhabricatorPinboardItemView.php +++ b/src/view/layout/PhabricatorPinboardItemView.php @@ -22,6 +22,8 @@ final class PhabricatorPinboardItemView extends AphrontView { private $uri; private $header; + private $imageWidth; + private $imageHeight; public function setHeader($header) { $this->header = $header;