From 5cc26f065d3f529e7092b0e49ccd51adbfade12d Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 5 Nov 2013 10:01:44 -0800
Subject: [PATCH] Expand "local working copy" conditional check in Diffusion

Summary: We don't care about any disk resources at all for non-hosted SVN repositories. See <https://github.com/facebook/phabricator/issues/428>.

Test Plan: Looked at a non-hosted SVN repo, saw no storage info.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D7506
---
 .../DiffusionRepositoryEditMainController.php | 40 +++++++++----------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
index 770ee87bde..5ba4423481 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
@@ -726,27 +726,27 @@ final class DiffusionRepositoryEditMainController
           ->setNote($daemon_instructions));
     }
 
-    $local_parent = dirname($repository->getLocalPath());
-    if (Filesystem::pathExists($local_parent)) {
-      $view->addItem(
-        id(new PHUIStatusItemView())
-          ->setIcon('accept-green')
-          ->setTarget(pht('Storage Directory OK'))
-          ->setNote(phutil_tag('tt', array(), $local_parent)));
-    } else {
-      $view->addItem(
-        id(new PHUIStatusItemView())
-          ->setIcon('warning-red')
-          ->setTarget(pht('No Storage Directory'))
-          ->setNote(
-            pht(
-              'Storage directory %s does not exist, or is not readable by '.
-              'the webserver. Create this directory or make it readable.',
-              phutil_tag('tt', array(), $local_parent))));
-      return $view;
-    }
-
     if ($repository->usesLocalWorkingCopy()) {
+      $local_parent = dirname($repository->getLocalPath());
+      if (Filesystem::pathExists($local_parent)) {
+        $view->addItem(
+          id(new PHUIStatusItemView())
+            ->setIcon('accept-green')
+            ->setTarget(pht('Storage Directory OK'))
+            ->setNote(phutil_tag('tt', array(), $local_parent)));
+      } else {
+        $view->addItem(
+          id(new PHUIStatusItemView())
+            ->setIcon('warning-red')
+            ->setTarget(pht('No Storage Directory'))
+            ->setNote(
+              pht(
+                'Storage directory %s does not exist, or is not readable by '.
+                'the webserver. Create this directory or make it readable.',
+                phutil_tag('tt', array(), $local_parent))));
+        return $view;
+      }
+
       $local_path = $repository->getLocalPath();
       $message = idx($messages, PhabricatorRepositoryStatusMessage::TYPE_INIT);
       if ($message) {