From 5ceca721cce3f874173aeaca6c72c2cae2e63c91 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Sun, 3 Sep 2017 09:39:19 -0700 Subject: [PATCH] Minor bug fix with PHUIInfoView Summary: Custom icons here aren't being set. Also use more standard `tt` UI. Test Plan: Set an icon, see set Icon. Reviewers: epriestley Reviewed By: epriestley Spies: Korvin Differential Revision: https://secure.phabricator.com/D18522 --- resources/celerity/map.php | 6 +++--- src/view/phui/PHUIInfoView.php | 1 + webroot/rsrc/css/phui/phui-info-view.css | 7 +++++-- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 7d07cde811..673f1952f1 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'conpherence.pkg.css' => 'e68cf1fa', 'conpherence.pkg.js' => 'b5b51108', - 'core.pkg.css' => '9dd62a98', + 'core.pkg.css' => '1071e7a2', 'core.pkg.js' => '6c085267', 'darkconsole.pkg.js' => '1f9a31bc', 'differential.pkg.css' => '45951e9e', @@ -163,7 +163,7 @@ return array( 'rsrc/css/phui/phui-icon-set-selector.css' => '87db8fee', 'rsrc/css/phui/phui-icon.css' => '5c4a5de6', 'rsrc/css/phui/phui-image-mask.css' => 'a8498f9c', - 'rsrc/css/phui/phui-info-view.css' => 'e1b4ec37', + 'rsrc/css/phui/phui-info-view.css' => '04e071d7', 'rsrc/css/phui/phui-invisible-character-view.css' => '6993d9f0', 'rsrc/css/phui/phui-left-right.css' => '75227a4d', 'rsrc/css/phui/phui-lightbox.css' => '0a035e40', @@ -851,7 +851,7 @@ return array( 'phui-icon-set-selector-css' => '87db8fee', 'phui-icon-view-css' => '5c4a5de6', 'phui-image-mask-css' => 'a8498f9c', - 'phui-info-view-css' => 'e1b4ec37', + 'phui-info-view-css' => '04e071d7', 'phui-inline-comment-view-css' => '65ae3bc2', 'phui-invisible-character-view-css' => '6993d9f0', 'phui-left-right-css' => '75227a4d', diff --git a/src/view/phui/PHUIInfoView.php b/src/view/phui/PHUIInfoView.php index 18f5af3374..161e49108b 100644 --- a/src/view/phui/PHUIInfoView.php +++ b/src/view/phui/PHUIInfoView.php @@ -59,6 +59,7 @@ final class PHUIInfoView extends AphrontTagView { } else { $icon = id(new PHUIIconView()) ->setIcon($icon); + $this->icon = $icon; } return $this; diff --git a/webroot/rsrc/css/phui/phui-info-view.css b/webroot/rsrc/css/phui/phui-info-view.css index 268385edec..7b20c63ccf 100644 --- a/webroot/rsrc/css/phui/phui-info-view.css +++ b/webroot/rsrc/css/phui/phui-info-view.css @@ -46,8 +46,11 @@ div.phui-info-view.phui-info-severity-plain { } .phui-info-view-body tt { - padding: 0 2px; - background-color: rgba({$alphagrey},.1); + color: {$blacktext}; + background: rgba({$alphablue},0.1); + padding: 1px 4px; + border-radius: 3px; + white-space: pre-wrap; } .phui-info-view-actions {