1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00

Fix some minor curtain overflow/wrap issues

Summary:
Fixes T12503.

  - Users with creative usernames like `MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM` could overflow "Subscribers" in the curtain UI.
  - Other content like packages could also overflow.
  - Users with interesting and unique names like `WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW` who were also away or disabled could get a linebreak between their availability dot and their username.

Test Plan:
See T12503 for "before" screenshots. Also tested mobile, which looked fine, but didn't screenshot it.

{F4849900}

{F4849912}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12503

Differential Revision: https://secure.phabricator.com/D17650
This commit is contained in:
epriestley 2017-04-10 15:07:07 -07:00
parent a7a068f84c
commit 5cf53f7b3b
3 changed files with 12 additions and 5 deletions

View file

@ -9,7 +9,7 @@ return array(
'names' => array( 'names' => array(
'conpherence.pkg.css' => '82aca405', 'conpherence.pkg.css' => '82aca405',
'conpherence.pkg.js' => '281b1a73', 'conpherence.pkg.js' => '281b1a73',
'core.pkg.css' => '1bf8fa70', 'core.pkg.css' => 'b519db07',
'core.pkg.js' => 'fbc1c380', 'core.pkg.js' => 'fbc1c380',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '90b30783', 'differential.pkg.css' => '90b30783',
@ -37,7 +37,7 @@ return array(
'rsrc/css/application/base/main-menu-view.css' => '5294060f', 'rsrc/css/application/base/main-menu-view.css' => '5294060f',
'rsrc/css/application/base/notification-menu.css' => '6a697e43', 'rsrc/css/application/base/notification-menu.css' => '6a697e43',
'rsrc/css/application/base/phui-theme.css' => '9f261c6b', 'rsrc/css/application/base/phui-theme.css' => '9f261c6b',
'rsrc/css/application/base/standard-page-view.css' => '894d8a25', 'rsrc/css/application/base/standard-page-view.css' => '285cedf3',
'rsrc/css/application/chatlog/chatlog.css' => 'd295b020', 'rsrc/css/application/chatlog/chatlog.css' => 'd295b020',
'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4', 'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
'rsrc/css/application/config/config-options.css' => '0ede4c9b', 'rsrc/css/application/config/config-options.css' => '0ede4c9b',
@ -139,7 +139,7 @@ return array(
'rsrc/css/phui/phui-comment-form.css' => '7d903c2d', 'rsrc/css/phui/phui-comment-form.css' => '7d903c2d',
'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad', 'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad',
'rsrc/css/phui/phui-crumbs-view.css' => '6ece3bbb', 'rsrc/css/phui/phui-crumbs-view.css' => '6ece3bbb',
'rsrc/css/phui/phui-curtain-view.css' => '947bf1a4', 'rsrc/css/phui/phui-curtain-view.css' => '679743bb',
'rsrc/css/phui/phui-document-pro.css' => 'f56738ed', 'rsrc/css/phui/phui-document-pro.css' => 'f56738ed',
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf', 'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
'rsrc/css/phui/phui-document.css' => 'c32e8dec', 'rsrc/css/phui/phui-document.css' => 'c32e8dec',
@ -798,7 +798,7 @@ return array(
'phabricator-shaped-request' => '7cbe244b', 'phabricator-shaped-request' => '7cbe244b',
'phabricator-slowvote-css' => 'a94b7230', 'phabricator-slowvote-css' => 'a94b7230',
'phabricator-source-code-view-css' => '4383192f', 'phabricator-source-code-view-css' => '4383192f',
'phabricator-standard-page-view' => '894d8a25', 'phabricator-standard-page-view' => '285cedf3',
'phabricator-textareautils' => '320810c8', 'phabricator-textareautils' => '320810c8',
'phabricator-title' => '485aaa6c', 'phabricator-title' => '485aaa6c',
'phabricator-tooltip' => '8fadb715', 'phabricator-tooltip' => '8fadb715',
@ -839,7 +839,7 @@ return array(
'phui-comment-form-css' => '7d903c2d', 'phui-comment-form-css' => '7d903c2d',
'phui-comment-panel-css' => 'f50152ad', 'phui-comment-panel-css' => 'f50152ad',
'phui-crumbs-view-css' => '6ece3bbb', 'phui-crumbs-view-css' => '6ece3bbb',
'phui-curtain-view-css' => '947bf1a4', 'phui-curtain-view-css' => '679743bb',
'phui-document-summary-view-css' => '9ca48bdf', 'phui-document-summary-view-css' => '9ca48bdf',
'phui-document-view-css' => 'c32e8dec', 'phui-document-view-css' => 'c32e8dec',
'phui-document-view-pro-css' => 'f56738ed', 'phui-document-view-pro-css' => 'f56738ed',

View file

@ -97,6 +97,11 @@ a.handle-status-closed:hover {
font-size: {$smallerfontsize}; font-size: {$smallerfontsize};
} }
.phui-handle.phui-link-person {
/* Prevent linebreaks between user availability markers and usernames. */
white-space: nowrap;
}
.phui-handle .phui-icon-view { .phui-handle .phui-icon-view {
display: inline-block; display: inline-block;
margin: 2px 2px -2px 0; margin: 2px 2px -2px 0;

View file

@ -24,6 +24,8 @@
.phui-curtain-panel-body { .phui-curtain-panel-body {
padding: 4px 0 0; padding: 4px 0 0;
overflow: hidden;
text-overflow: ellipsis;
} }
.device .phui-curtain-panel-body { .device .phui-curtain-panel-body {