From 5d377e246a56be18f6d5ecc604c6ddaf5cf13ec6 Mon Sep 17 00:00:00 2001 From: Marek Sapota Date: Tue, 18 Oct 2011 12:13:23 -0700 Subject: [PATCH] Send patch attachments instead of diff attachments. Test Plan: Turn on sending patches, create a new revision - you should get a .patch file in your mail instead of a .diff file. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: 1016 --- .../mail/reviewrequest/DifferentialReviewRequestMail.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php b/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php index f08d6f3a85..2a88dcec60 100644 --- a/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php +++ b/src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php @@ -88,7 +88,7 @@ abstract class DifferentialReviewRequestMail extends DifferentialMail { $diff_number = count($diffs); $diff = array_pop($diffs); - $filename = "D{$revision_id}.{$diff_number}.diff"; + $filename = "D{$revision_id}.{$diff_number}.patch"; $diff->attachChangesets($diff->loadChangesets()); // TODO: We could batch this to improve performance. @@ -107,7 +107,7 @@ abstract class DifferentialReviewRequestMail extends DifferentialMail { $attachments[] = array( 'data' => $unified_diff, 'filename' => $filename, - 'mimetype' => 'text/x-diff; charset=utf-8' + 'mimetype' => 'text/x-patch; charset=utf-8' ); } return $attachments;