Improve task list filtering views.

Summary:

Test Plan:

Reviewers:

CC:

src/applications/maniphest/controller/tasklist/ManiphestTaskListController.php

@@ -27,21 +27,35 @@ class ManiphestTaskListController extends ManiphestController {
   public function processRequest() {
 
     $views = array(
+      'Your Tasks',
       'action'    => 'Action Required',
 //      'activity'  => 'Recently Active',
 //      'closed'    => 'Recently Closed',
       'created'   => 'Created',
       'triage'    => 'Need Triage',
+      '<hr />',
+      'All Open Tasks',
+      'alltriage'   => 'Need Triage',
+      'unassigned'  => 'Unassigned',
+      'allopen'     => 'All Open',
+      
     );
 
     if (empty($views[$this->view])) {
-      $this->view = key($views);
+      $this->view = 'action';
     }
 
     $tasks = $this->loadTasks();
 
     $nav = new AphrontSideNavView();
     foreach ($views as $view => $name) {
+      if (is_integer($view)) {
+        $nav->addNavItem(
+          phutil_render_tag(
+            'span',
+            array(),
+            $name));
+      } else {
         $nav->addNavItem(
           phutil_render_tag(
             'a',
@@ -53,6 +67,7 @@ class ManiphestTaskListController extends ManiphestController {
             ),
             phutil_escape_html($name)));
       }
+    }
 
     $handle_phids = mpull($tasks, 'getOwnerPHID');
     $handles = id(new PhabricatorObjectHandleData($handle_phids))
@@ -93,9 +108,20 @@ class ManiphestTaskListController extends ManiphestController {
           'authorPHID in (%Ls) AND status = 0',
           $phids);
       case 'triage':
+        return id(new ManiphestTask())->loadAllWhere(
+          'ownerPHID in (%Ls) and status = %d',
+          $phids,
+          ManiphestTaskPriority::PRIORITY_TRIAGE);
+      case 'alltriage':
         return id(new ManiphestTask())->loadAllWhere(
           'status = %d',
           ManiphestTaskPriority::PRIORITY_TRIAGE);
+      case 'unassigned':
+        return id(new ManiphestTask())->loadAllWhere(
+          'ownerPHID IS NULL');
+      case 'allopen':
+        return id(new ManiphestTask())->loadAllWhere(
+          'status = 0');
     }
 
     return array();

src/applications/maniphest/editor/transaction/ManiphestTransactionEditor.php

@@ -147,7 +147,6 @@ class ManiphestTransactionEditor {
       "TASK DETAIL\n".
       "  ".$task_uri."\n";
 
-
     $base = substr(md5($task->getPHID()), 0, 27).' '.pack("N", time());
     $thread_index = base64_encode($base);
 

webroot/rsrc/css/aphront/side-nav-view.css

@@ -15,7 +15,8 @@ th.aphront-side-nav-navigation {
   border-right: 1px solid #bbbbbb;
 }
 
-th.aphront-side-nav-navigation a {
+th.aphront-side-nav-navigation a,
+th.aphront-side-nav-navigation span {
   display: block;
   margin: 0 0 2px;
   min-width: 150px;