1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00

Fix deprecated argument order for "implode()"

Summary: Fixes T13428. In modern PHP, "implode()" should take the glue parameter first.

Test Plan:
Used the linter introduced in D20857 to identify affected callsites.

```
$ git grep -i implode | cut -d: -f1 | sort | uniq | xargs arc lint --output summary --never-apply-patches | grep -i glue
```

Maniphest Tasks: T13428

Differential Revision: https://secure.phabricator.com/D20858
This commit is contained in:
epriestley 2019-10-17 09:06:13 -07:00
parent 7badec23a7
commit 5dafabd5b4
5 changed files with 6 additions and 6 deletions

View file

@ -103,7 +103,7 @@ final class PhabricatorDifferentialRevisionTestDataGenerator
$newcode2[] = $altcodearr[$randomlines_new[$c++]];
}
}
return implode($newcode2, "\n");
return implode("\n", $newcode2);
}
}

View file

@ -38,7 +38,7 @@ final class PhabricatorUserCardView extends AphrontTagView {
}
return array(
'class' => implode($classes, ' '),
'class' => implode(' ', $classes),
);
}

View file

@ -36,7 +36,7 @@ final class PhabricatorProjectCardView extends AphrontTagView {
$classes[] = 'project-card-'.$color;
return array(
'class' => implode($classes, ' '),
'class' => implode(' ', $classes),
);
}

View file

@ -284,7 +284,7 @@ final class PHUIPropertyListView extends AphrontView {
return phutil_tag(
'div',
array(
'class' => implode($classes, ' '),
'class' => implode(' ', $classes),
),
$part['content']);
}
@ -295,7 +295,7 @@ final class PHUIPropertyListView extends AphrontView {
return phutil_tag(
'div',
array(
'class' => implode($classes, ' '),
'class' => implode(' ', $classes),
),
$part['content']);
}

View file

@ -220,7 +220,7 @@ final class PHUITwoColumnView extends AphrontTagView {
return phutil_tag(
'div',
array(
'class' => implode($classes, ' '),
'class' => implode(' ', $classes),
),
array(
$navigation,