From 5dca350e0e79b7568277948622be0b7730f93fc1 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 12 Jun 2014 11:27:30 -0700 Subject: [PATCH] Move icon inside link in ActionLink Summary: Moves the icon into the link Test Plan: Tested a form (Phrequent), disabled, and regular action link Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5331 Differential Revision: https://secure.phabricator.com/D9503 --- src/view/layout/PhabricatorActionView.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/view/layout/PhabricatorActionView.php b/src/view/layout/PhabricatorActionView.php index befef4d2bf..293d1d0926 100644 --- a/src/view/layout/PhabricatorActionView.php +++ b/src/view/layout/PhabricatorActionView.php @@ -140,7 +140,7 @@ final class PhabricatorActionView extends AphrontView { array( 'class' => 'phabricator-action-view-item', ), - $this->name); + array($icon, $this->name)); $item = phabricator_form( $this->user, @@ -160,7 +160,7 @@ final class PhabricatorActionView extends AphrontView { 'sigil' => $sigils, 'meta' => $this->metadata, ), - $this->name); + array($icon, $this->name)); } } else { $item = phutil_tag( @@ -168,7 +168,7 @@ final class PhabricatorActionView extends AphrontView { array( 'class' => 'phabricator-action-view-item', ), - $this->name); + array($icon, $this->name)); } $classes = array(); @@ -186,7 +186,7 @@ final class PhabricatorActionView extends AphrontView { array( 'class' => implode(' ', $classes), ), - array($icon, $item)); + $item); } }