revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php:33]
```

Closes T15684

Test Plan: After configuring a custom `text` field and a dashboard panel to query and listed the latest created tasks, access the panel.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15684

Differential Revision: https://we.phorge.it/D25488
This commit is contained in:
Andre Klapper 2023-12-06 10:29:32 -08:00
parent c8a9270060
commit 5ddca7da55
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php
View file

@ -11,7 +11,7 @@ final class PhabricatorStandardCustomFieldText
$indexes = array(); $indexes = array();
$value = $this->getFieldValue(); $value = $this->getFieldValue();
if (strlen($value)) { if (phutil_nonempty_string($value)) {
$indexes[] = $this->newStringIndex($value); $indexes[] = $this->newStringIndex($value);
} }
@ -30,7 +30,7 @@ final class PhabricatorStandardCustomFieldText
PhabricatorCursorPagedPolicyAwareQuery $query, PhabricatorCursorPagedPolicyAwareQuery $query,
$value) { $value) {
if (strlen($value)) { if (phutil_nonempty_string($value)) {
$query->withApplicationSearchContainsConstraint( $query->withApplicationSearchContainsConstraint(
$this->newStringIndex(null), $this->newStringIndex(null),
$value); $value);