From 5e48e16f77fd918607cb943f1b1f78293bb00cee Mon Sep 17 00:00:00 2001
From: Steve Campbell <steve.campbell@virginmedia.co.uk>
Date: Tue, 4 Jul 2023 16:24:12 +0100
Subject: [PATCH] Update DiffusionDocumentRenderingEngine to cope with null
 code coverage in PHP 8.1

Summary:
Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP 8.1

Fixes T15523

Test Plan: https://my.phorge.site/source/myrepo/browse/master/myfile

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15523

Differential Revision: https://we.phorge.it/D25330
---
 .../diffusion/document/DiffusionDocumentRenderingEngine.php     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/diffusion/document/DiffusionDocumentRenderingEngine.php b/src/applications/diffusion/document/DiffusionDocumentRenderingEngine.php
index 800d195726..2c33a82ad5 100644
--- a/src/applications/diffusion/document/DiffusionDocumentRenderingEngine.php
+++ b/src/applications/diffusion/document/DiffusionDocumentRenderingEngine.php
@@ -87,7 +87,7 @@ final class DiffusionDocumentRenderingEngine
     $ref->setSymbolMetadata($this->getSymbolMetadata());
 
     $coverage = $drequest->loadCoverage();
-    if (strlen($coverage)) {
+    if (phutil_nonempty_string($coverage)) {
       $ref->addCoverage($coverage);
     }
   }