From 5ea071f65834861c68cc1ce8f4493e1dfd77b814 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 16 Dec 2016 07:11:19 -0800
Subject: [PATCH] Remove "DifferentialGitSVNIDField" custom field in
 Differential

Summary: Ref T11114. This is obsolted by the narrower `DifferentialGitSVNIDCommitMessageField`.

Test Plan: Browsed around.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17075
---
 src/__phutil_library_map__.php                |  2 -
 .../customfield/DifferentialGitSVNIDField.php | 45 -------------------
 2 files changed, 47 deletions(-)
 delete mode 100644 src/applications/differential/customfield/DifferentialGitSVNIDField.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index c2da058d1c..41826e0343 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -445,7 +445,6 @@ phutil_register_library_map(array(
     'DifferentialGetWorkingCopy' => 'applications/differential/DifferentialGetWorkingCopy.php',
     'DifferentialGitHubLandingStrategy' => 'applications/differential/landing/DifferentialGitHubLandingStrategy.php',
     'DifferentialGitSVNIDCommitMessageField' => 'applications/differential/field/DifferentialGitSVNIDCommitMessageField.php',
-    'DifferentialGitSVNIDField' => 'applications/differential/customfield/DifferentialGitSVNIDField.php',
     'DifferentialHarbormasterField' => 'applications/differential/customfield/DifferentialHarbormasterField.php',
     'DifferentialHiddenComment' => 'applications/differential/storage/DifferentialHiddenComment.php',
     'DifferentialHostField' => 'applications/differential/customfield/DifferentialHostField.php',
@@ -5095,7 +5094,6 @@ phutil_register_library_map(array(
     'DifferentialGetWorkingCopy' => 'Phobject',
     'DifferentialGitHubLandingStrategy' => 'DifferentialLandingStrategy',
     'DifferentialGitSVNIDCommitMessageField' => 'DifferentialCommitMessageField',
-    'DifferentialGitSVNIDField' => 'DifferentialCustomField',
     'DifferentialHarbormasterField' => 'DifferentialCustomField',
     'DifferentialHiddenComment' => 'DifferentialDAO',
     'DifferentialHostField' => 'DifferentialCustomField',
diff --git a/src/applications/differential/customfield/DifferentialGitSVNIDField.php b/src/applications/differential/customfield/DifferentialGitSVNIDField.php
deleted file mode 100644
index de45c54c7f..0000000000
--- a/src/applications/differential/customfield/DifferentialGitSVNIDField.php
+++ /dev/null
@@ -1,45 +0,0 @@
-<?php
-
-/**
- * This field doesn't do anything, it just parses the "git-svn-id" field which
- * `git svn` inserts into commit messages so that we don't end up mangling
- * some other field.
- */
-final class DifferentialGitSVNIDField
-  extends DifferentialCustomField {
-
-  public function getFieldKey() {
-    return 'differential:git-svn-id';
-  }
-
-  public function getFieldKeyForConduit() {
-    return 'gitSVNID';
-  }
-
-  public function getFieldName() {
-    return pht('git-svn-id');
-  }
-
-  public function getFieldDescription() {
-    return pht(
-      'Parses the "%s" field which Git/SVN can inject into commit messages.',
-      'git-svn-id');
-  }
-
-  public function canDisableField() {
-    return false;
-  }
-
-  public function shouldAppearInCommitMessage() {
-    return true;
-  }
-
-  public function shouldAllowEditInCommitMessage() {
-    return false;
-  }
-
-  public function renderCommitMessageValue(array $handles) {
-    return null;
-  }
-
-}