revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

Only validate form subtype edits if subtype transactions are present

Browse source 
Summary: Fixes T12347. Ref T12314. Validation gets called no matter what, but is only relevant if the form supports subtypes.

Test Plan: Marked/unmarked a Paste form as editable.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12347, T12314

Differential Revision: https://secure.phabricator.com/D17457
This commit is contained in:
epriestley 2017-03-03 13:41:44 -08:00
parent d2a420d13a
commit 5ed90b2235
1 changed files with 15 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php
View file

@ -57,6 +57,7 @@ final class PhabricatorEditEngineConfigurationEditor
} }
break; break;
case PhabricatorEditEngineConfigurationTransaction::TYPE_SUBTYPE: case PhabricatorEditEngineConfigurationTransaction::TYPE_SUBTYPE:
if ($xactions) {
$map = $object->getEngine() $map = $object->getEngine()
->setViewer($this->getActor()) ->setViewer($this->getActor())
->newSubtypeMap(); ->newSubtypeMap();
@ -73,6 +74,7 @@ final class PhabricatorEditEngineConfigurationEditor
pht('Subtype "%s" is not a valid subtype.', $new), pht('Subtype "%s" is not a valid subtype.', $new),
$xaction); $xaction);
} }
}
break; break;
} }