Move Diffusion ReadmeView to PHUIDocumentProView

Summary: Swapping out to PHUIDocumentProView to remove all calls to PHUIDocumentView.

Test Plan: Review the Phabricator Readme.MD in Diffusion

Reviewers: epriestley, avivey

Reviewed By: avivey

Subscribers: avivey, Korvin

Differential Revision: https://secure.phabricator.com/D15308

resources/celerity/map.php

@@ -65,7 +65,7 @@ return array(
     'rsrc/css/application/differential/revision-list.css' => 'f3c47d33',
     'rsrc/css/application/differential/table-of-contents.css' => 'ae4b7a55',
     'rsrc/css/application/diffusion/diffusion-icons.css' => '2941baf1',
-    'rsrc/css/application/diffusion/diffusion-readme.css' => '2106ea08',
+    'rsrc/css/application/diffusion/diffusion-readme.css' => '356a4f3c',
     'rsrc/css/application/diffusion/diffusion-source.css' => '075ba788',
     'rsrc/css/application/feed/feed.css' => 'ecd4ec57',
     'rsrc/css/application/files/global-drag-and-drop.css' => '5c1b47c2',
@@ -551,7 +551,7 @@ return array(
     'differential-revision-list-css' => 'f3c47d33',
     'differential-table-of-contents-css' => 'ae4b7a55',
     'diffusion-icons-css' => '2941baf1',
-    'diffusion-readme-css' => '2106ea08',
+    'diffusion-readme-css' => '356a4f3c',
     'diffusion-source-css' => '075ba788',
     'diviner-shared-css' => 'aa3656aa',
     'font-aleo' => '8bdb2835',

src/applications/diffusion/view/DiffusionReadmeView.php

@@ -109,11 +109,14 @@ final class DiffusionReadmeView extends DiffusionView {
     $header = id(new PHUIHeaderView())
       ->setHeader($readme_name);
 
-    return id(new PHUIDocumentView())
+    $document = id(new PHUIDocumentViewPro())
       ->setFluid(true)
-      ->appendChild($readme_content)
-      ->addClass('diffusion-readme-view')
-      ->setHeader($header);
+      ->appendChild($readme_content);
+
+    return id(new PHUIObjectBoxView())
+      ->setHeader($header)
+      ->appendChild($document)
+      ->addClass('diffusion-readme-view');
   }
 
 }

webroot/rsrc/css/application/diffusion/diffusion-readme.css

@@ -2,13 +2,12 @@
  * @provides diffusion-readme-css
  */
 
-.device .diffusion-readme-view {
-  margin: 16px 8px 0;
-  background-color: #fff;
-  border: 1px solid {$lightblueborder};
-  border-bottom: 1px solid {$blueborder};
+.device-desktop .diffusion-readme-view .phui-document-fluid
+  .phui-document-view {
+    margin: 0;
+    padding: 0 8px;
 }
 
-.device-tablet .diffusion-readme-view {
-  margin: 16px;
+.diffusion-readme-view .phui-document-container {
+  border: none;
 }